Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174513003: Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 3). (Closed)

Created:
6 years, 10 months ago by Yoyo Zhou
Modified:
6 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered, miu+watch_chromium.org
Visibility:
Public.

Description

Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 3). This is the last part. Follows part 1: https://chromiumcodereview.appspot.com/171813010/ BUG=309909 R=jamescook@chromium.org TBR=brettw@chromium.org, dtseng@chromium.org, erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -266 lines) Patch
M chrome/browser/extensions/api/serial/serial_event_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_event_dispatcher.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.h View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/tcp_socket_event_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/tcp_socket_event_dispatcher.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/sockets_udp/udp_socket_event_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sockets_udp/udp_socket_event_dispatcher.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/spellcheck/spellcheck_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/spellcheck/spellcheck_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_api.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_windows_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_windows_api.cc View 3 chunks +34 lines, -37 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 2 chunks +22 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry.h View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 2 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_override_registrar.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui_override_registrar.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/plugin_manager.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/plugin_manager.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.cc View 4 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/search/hotword_service_factory.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/search/hotword_service_factory.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Yoyo Zhou
This one's like the last one.
6 years, 10 months ago (2014-02-21 02:15:44 UTC) #1
James Cook
LGTM. Sorry for the delay, I've been swamped with the NativeAppWindow refactor.
6 years, 10 months ago (2014-02-21 22:47:13 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-24 21:36:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/174513003/1
6 years, 10 months ago (2014-02-24 21:38:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 22:07:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=51750
6 years, 10 months ago (2014-02-24 22:07:10 UTC) #6
Yoyo Zhou
TBR for uninteresting refactoring: erg (chrome/browser/profiles) brettw (chrome/browser/search) dtseng (chrome/browser/speech)
6 years, 10 months ago (2014-02-24 22:10:38 UTC) #7
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-24 22:10:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/174513003/1
6 years, 10 months ago (2014-02-24 22:12:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/174513003/1
6 years, 10 months ago (2014-02-25 01:33:50 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 04:52:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 04:52:56 UTC) #12
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-25 16:32:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/174513003/1
6 years, 10 months ago (2014-02-25 16:35:01 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 16:38:32 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 16:38:32 UTC) #16
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-25 16:59:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/174513003/1
6 years, 10 months ago (2014-02-25 16:59:25 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 17:01:14 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 17:01:15 UTC) #20
Yoyo Zhou
6 years, 10 months ago (2014-02-25 19:24:49 UTC) #21
Message was sent while issue was closed. 
Committed patchset #1 manually as r253223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698