Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: net/disk_cache/stats_histogram.cc

Issue 17451016: [UMA] Remove redundant bucket_count variable from base::Histogram. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename variables to be clearer Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/stats_histogram.h ('k') | net/dns/dns_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/stats_histogram.cc
diff --git a/net/disk_cache/stats_histogram.cc b/net/disk_cache/stats_histogram.cc
index 7499ab23edb3af45e415938acce206b55601d0bd..33adfeaae49986947eac69ba0ccee97b33bdc965 100644
--- a/net/disk_cache/stats_histogram.cc
+++ b/net/disk_cache/stats_histogram.cc
@@ -23,10 +23,9 @@ using base::StatisticsRecorder;
StatsHistogram::StatsHistogram(const std::string& name,
Sample minimum,
Sample maximum,
- size_t bucket_count,
const BucketRanges* ranges,
const Stats* stats)
- : Histogram(name, minimum, maximum, bucket_count, ranges),
+ : Histogram(name, minimum, maximum, ranges),
stats_(stats) {}
StatsHistogram::~StatsHistogram() {}
@@ -34,7 +33,7 @@ StatsHistogram::~StatsHistogram() {}
// static
void StatsHistogram::InitializeBucketRanges(const Stats* stats,
BucketRanges* ranges) {
- for (size_t i = 0; i < ranges->size(); i++) {
+ for (size_t i = 0; i < ranges->size(); ++i) {
ranges->set_range(i, stats->GetBucketRange(i));
}
ranges->ResetChecksum();
@@ -57,8 +56,7 @@ StatsHistogram* StatsHistogram::FactoryGet(const std::string& name,
// To avoid racy destruction at shutdown, the following will be leaked.
StatsHistogram* stats_histogram =
- new StatsHistogram(name, minimum, maximum, bucket_count,
- registered_ranges, stats);
+ new StatsHistogram(name, minimum, maximum, registered_ranges, stats);
stats_histogram->SetFlags(kUmaTargetedHistogramFlag);
histogram = StatisticsRecorder::RegisterOrDeleteDuplicate(stats_histogram);
}
« no previous file with comments | « net/disk_cache/stats_histogram.h ('k') | net/dns/dns_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698