Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2535)

Unified Diff: base/metrics/histogram_unittest.cc

Issue 17451016: [UMA] Remove redundant bucket_count variable from base::Histogram. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename variables to be clearer Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_base.h ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_unittest.cc
diff --git a/base/metrics/histogram_unittest.cc b/base/metrics/histogram_unittest.cc
index b5081b6ce54ccdd36d5e5942c1e791488d278126..6ff7d00436578e2357065c71023c6aaae775d086 100644
--- a/base/metrics/histogram_unittest.cc
+++ b/base/metrics/histogram_unittest.cc
@@ -90,7 +90,7 @@ TEST_F(HistogramTest, NameMatchTest) {
TEST_F(HistogramTest, ExponentialRangesTest) {
// Check that we got a nice exponential when there was enough rooom.
BucketRanges ranges(9);
- Histogram::InitializeBucketRanges(1, 64, 8, &ranges);
+ Histogram::InitializeBucketRanges(1, 64, &ranges);
EXPECT_EQ(0, ranges.range(0));
int power_of_2 = 1;
for (int i = 1; i < 8; i++) {
@@ -107,7 +107,7 @@ TEST_F(HistogramTest, ExponentialRangesTest) {
// When bucket count is limited, exponential ranges will partially look like
// linear.
BucketRanges ranges2(16);
- Histogram::InitializeBucketRanges(1, 32, 15, &ranges2);
+ Histogram::InitializeBucketRanges(1, 32, &ranges2);
EXPECT_EQ(0, ranges2.range(0));
EXPECT_EQ(1, ranges2.range(1));
@@ -134,7 +134,7 @@ TEST_F(HistogramTest, ExponentialRangesTest) {
TEST_F(HistogramTest, LinearRangesTest) {
BucketRanges ranges(9);
- LinearHistogram::InitializeBucketRanges(1, 7, 8, &ranges);
+ LinearHistogram::InitializeBucketRanges(1, 7, &ranges);
// Gets a nice linear set of bucket ranges.
for (int i = 0; i < 8; i++)
EXPECT_EQ(i, ranges.range(i));
@@ -147,7 +147,7 @@ TEST_F(HistogramTest, LinearRangesTest) {
// Linear ranges are not divisible.
BucketRanges ranges2(6);
- LinearHistogram::InitializeBucketRanges(1, 6, 5, &ranges2);
+ LinearHistogram::InitializeBucketRanges(1, 6, &ranges2);
EXPECT_EQ(0, ranges2.range(0));
EXPECT_EQ(1, ranges2.range(1));
EXPECT_EQ(3, ranges2.range(2));
« no previous file with comments | « base/metrics/histogram_base.h ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698