Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: base/metrics/bucket_ranges_unittest.cc

Issue 17451016: [UMA] Remove redundant bucket_count variable from base::Histogram. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename variables to be clearer Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/metrics/bucket_ranges.h ('k') | base/metrics/histogram.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/metrics/bucket_ranges.h" 5 #include "base/metrics/bucket_ranges.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace base { 9 namespace base {
10 namespace { 10 namespace {
11 11
12 TEST(BucketRangesTest, NormalSetup) { 12 TEST(BucketRangesTest, NormalSetup) {
13 BucketRanges ranges(5); 13 BucketRanges ranges(5);
14 ASSERT_EQ(5u, ranges.size()); 14 ASSERT_EQ(5u, ranges.size());
15 ASSERT_EQ(4u, ranges.bucket_count());
15 16
16 for (int i = 0; i < 5; i++) { 17 for (int i = 0; i < 5; ++i) {
17 EXPECT_EQ(0, ranges.range(i)); 18 EXPECT_EQ(0, ranges.range(i));
18 } 19 }
19 EXPECT_EQ(0u, ranges.checksum()); 20 EXPECT_EQ(0u, ranges.checksum());
20 21
21 ranges.set_range(3, 100); 22 ranges.set_range(3, 100);
22 EXPECT_EQ(100, ranges.range(3)); 23 EXPECT_EQ(100, ranges.range(3));
23 } 24 }
24 25
25 TEST(BucketRangesTest, Equals) { 26 TEST(BucketRangesTest, Equals) {
26 // Compare empty ranges. 27 // Compare empty ranges.
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 checksum = kReversedPolynomial ^ (checksum >> 1); 83 checksum = kReversedPolynomial ^ (checksum >> 1);
83 else 84 else
84 checksum >>= 1; 85 checksum >>= 1;
85 } 86 }
86 EXPECT_EQ(kCrcTable[i], checksum); 87 EXPECT_EQ(kCrcTable[i], checksum);
87 } 88 }
88 } 89 }
89 90
90 } // namespace 91 } // namespace
91 } // namespace base 92 } // namespace base
OLDNEW
« no previous file with comments | « base/metrics/bucket_ranges.h ('k') | base/metrics/histogram.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698