Drop memory class-based renderer limit on Android.

Drop memory class-based renderer limit on Android.

This patch removes the automatic renderer-process limit on Android, moving the
consumers to MAX_RENDERERS_LIMIT instead.

This does not affect the number of renderers being spawned yet, but will allow
the consumers to use all available renderers once MAX_RENDERERS_LIMIT is
lifted.

BUG=241787
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208095

[ppi, 2013-06-20 17:16:22]

Could you guys have a look?

This can be landed after the corresponding Chrome on Android patch lands, then
the final step will be to change MAX_REGISTERED_SANDBOXED_SERVICES from 6 to 13.

[Yaron, 2013-06-21 21:21:28]

https://codereview.chromium.org/17450020/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java
(left):

https://codereview.chromium.org/17450020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java:16:
// NOTE: This file hasn't been fully upstreamed, please don't merge to
downstream.
Nice

https://codereview.chromium.org/17450020/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java
(right):

https://codereview.chromium.org/17450020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java:71:
Log.w(TAG, "Excessive maxRendererProcesses value: " + maxRendererProcesses);
Maybe Log.wtf? Seems like a critical failure. Actually, you can just assert it
above like you ensure it's > 0 and then get rid of the min.

[Yaron, 2013-06-21 21:21:48]

Err lgtm minus small comments

[klobag.chromium, 2013-06-22 15:41:50]

lgtm

https://chromiumcodereview.appspot.com/17450020/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java
(right):

https://chromiumcodereview.appspot.com/17450020/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java:32:
public static final int MAX_RENDERERS_LIMIT =
FYI, as mentioned in
https://code.google.com/p/chromium/issues/detail?id=251279#c10, we probably want
to add another buffer process. So MAX_RENDERERS_LIMIT =
ChildProcessLauncher.MAX_REGISTERED_SANDBOXED_SERVICES - 4;

[ppi, 2013-06-22 19:01:52]

Thanks a lot!

I have addressed the remarks in patch set 2 and in the comments below, and I
intend to proceed with a commit.

https://codereview.chromium.org/17450020/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java
(right):

https://codereview.chromium.org/17450020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java:32:
public static final int MAX_RENDERERS_LIMIT =
On 2013/06/22 15:41:50, klobag.chromium wrote:
> FYI, as mentioned in
> https://code.google.com/p/chromium/issues/detail?id=251279#c10, we probably
want
> to add another buffer process. So MAX_RENDERERS_LIMIT =
> ChildProcessLauncher.MAX_REGISTERED_SANDBOXED_SERVICES - 4;

Thanks! If that's fine with you, I will make this change in the patch that will
change MAX_REGISTERED_SANDBOXED_SERVICES to 13 (in this patch we still stay at
6).

https://codereview.chromium.org/17450020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java:71:
Log.w(TAG, "Excessive maxRendererProcesses value: " + maxRendererProcesses);
On 2013/06/21 21:21:28, Yaron wrote:
> Maybe Log.wtf? Seems like a critical failure. Actually, you can just assert it
> above like you ensure it's > 0 and then get rid of the min.

Done.

[commit-bot: I haz the power, 2013-06-22 19:02:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/17450020/9002

[commit-bot: I haz the power, 2013-06-22 22:33:15]

Change committed as 208095