Fix test failure in list_selection_model_test.html and port to automated browser test.

Fix test failure in list_selection_model_test.html and port to automated browser test.

BUG=249104
TEST=WebUIResourceBrowserTest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207855

[kevers, 2013-06-20 15:16:38]

Erik and Dan,

Can you please have a look at this CL.

[arv (Not doing code reviews), 2013-06-20 15:25:01]

LGTM

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
File chrome/test/data/webui/list_selection_model_test.html (right):

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:95: // crbug/81802).
I'm not sure this comment makes sense now. The bug is marked as fixed and we
decided to select next item instead of no item.

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:75: * Verifies that the contents
of the expected and observed arrays match.
rebase

[Dan Beam, 2013-06-20 18:23:39]

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
File chrome/test/data/webui/list_selection_model_test.html (right):

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:17: 
doc, assert(start % end == 0);

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:25: 
i'm 12 and what is this? (needs doc)

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:161: // crbug/81802).
if these bug references stay, make real links (so my lazy butt can click them
from bash)

[kevers, 2013-06-20 20:03:34]

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
File chrome/test/data/webui/list_selection_model_test.html (right):

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:17: 
On 2013/06/20 18:23:39, Dan Beam wrote:
> doc, assert(start % end == 0);

Added jsdoc.

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:25: 
On 2013/06/20 18:23:39, Dan Beam wrote:
> i'm 12 and what is this? (needs doc)

Done.

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:95: // crbug/81802).
On 2013/06/20 15:25:01, arv wrote:
> I'm not sure this comment makes sense now. The bug is marked as fixed and we
> decided to select next item instead of no item.

removed comment.

https://chromiumcodereview.appspot.com/17450012/diff/1012/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:161: // crbug/81802).
On 2013/06/20 18:23:39, Dan Beam wrote:
> if these bug references stay, make real links (so my lazy butt can click them
> from bash)

Removed comment.

[Dan Beam, 2013-06-20 21:38:03]

lgtm

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
File chrome/test/data/webui/list_selection_model_test.html (right):

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:21: * @param{nubmer} end
The last number in the range inclusive.
@param\s, s/nubmer/number/

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:22: * @return
{Array.<number>}
!Array

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:34: * @param
{!ListSelectionModel) sm The selection model to adjust.
s/)/}/

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:34: * @param
{!ListSelectionModel) sm The selection model to adjust.
nit: s/sm/model/

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:76: * @param {Array} expected The
expected result.
!Array

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:80: var v1 =
Array.prototype.slice.call(expected);
Array.prototype.slice.call(null)
TypeError: Array.prototype.slice called on null or undefined

[kevers, 2013-06-21 13:30:49]

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
File chrome/test/data/webui/list_selection_model_test.html (right):

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:21: * @param{nubmer} end
The last number in the range inclusive.
On 2013/06/20 21:38:03, Dan Beam wrote:
> @param\s, s/nubmer/number/

Done.

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:22: * @return
{Array.<number>}
On 2013/06/20 21:38:03, Dan Beam wrote:
> !Array

Done.

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:34: * @param
{!ListSelectionModel) sm The selection model to adjust.
On 2013/06/20 21:38:03, Dan Beam wrote:
> s/)/}/

Done.

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/list_selection_model_test.html:34: * @param
{!ListSelectionModel) sm The selection model to adjust.
On 2013/06/20 21:38:03, Dan Beam wrote:
> nit: s/sm/model/

Done.

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
File chrome/test/data/webui/webui_resource_test.js (right):

https://chromiumcodereview.appspot.com/17450012/diff/7001/chrome/test/data/we...
chrome/test/data/webui/webui_resource_test.js:76: * @param {Array} expected The
expected result.
On 2013/06/20 21:38:03, Dan Beam wrote:
> !Array

Done.

[commit-bot: I haz the power, 2013-06-21 13:31:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/17450012/14001

[commit-bot: I haz the power, 2013-06-21 16:31:35]

Change committed as 207855