Issue 17450008: [Downloads] Make DownloadTestObserverTerminal condition on IsDone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17450008: [Downloads] Make DownloadTestObserverTerminal condition on IsDone (Closed)

Created:
7 years, 6 months ago by asanka

Modified:
7 years, 6 months ago

Reviewers:
benjhayden, Jói

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, jam, joi+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Downloads] Make DownloadTestObserverTerminal condition on IsDone The terminal state of a download is determined by DownloadItem::IsDone() rather than watching for a download that has a state other than IN_PROGRESS. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207711

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -6 lines)			Patch
M	content/browser/download/download_browsertest.cc	View	5 chunks	+15 lines, -4 lines	0 comments	Download
M	content/public/test/download_test_observer.h	View	2 chunks	+19 lines, -1 line	0 comments	Download
M	content/public/test/download_test_observer.cc	View	2 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

asanka

PTAL. This is cleanup + clearing the path for additional resumption tests.

7 years, 6 months ago (2013-06-19 18:49:42 UTC) #1

asanka

On 2013/06/20 19:33:21, benjhayden_chromium wrote: > lgtm Thanks! + joi for content/public

7 years, 6 months ago (2013-06-20 20:27:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/17450008/1

7 years, 6 months ago (2013-06-20 21:39:33 UTC) #6

Message was sent while issue was closed.

Change committed as 207711

Expand Messages | Collapse Messages