Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/type-info.cc

Issue 17448017: Fix the flags used to probe the megamorphic code cache. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 return Code::GetKeyedAccessStoreMode(code->extra_ic_state()); 240 return Code::GetKeyedAccessStoreMode(code->extra_ic_state());
241 } 241 }
242 } 242 }
243 return STANDARD_STORE; 243 return STANDARD_STORE;
244 } 244 }
245 245
246 246
247 void TypeFeedbackOracle::LoadReceiverTypes(Property* expr, 247 void TypeFeedbackOracle::LoadReceiverTypes(Property* expr,
248 Handle<String> name, 248 Handle<String> name,
249 SmallMapList* types) { 249 SmallMapList* types) {
250 Code::Flags flags = Code::ComputeMonomorphicFlags(Code::LOAD_IC); 250 Code::Flags flags = Code::ComputeFlags(
251 Code::STUB, MONOMORPHIC, Code::kNoExtraICState,
252 Code::NORMAL, Code::LOAD_IC);
251 CollectReceiverTypes(expr->PropertyFeedbackId(), name, flags, types); 253 CollectReceiverTypes(expr->PropertyFeedbackId(), name, flags, types);
252 } 254 }
253 255
254 256
255 void TypeFeedbackOracle::StoreReceiverTypes(Assignment* expr, 257 void TypeFeedbackOracle::StoreReceiverTypes(Assignment* expr,
256 Handle<String> name, 258 Handle<String> name,
257 SmallMapList* types) { 259 SmallMapList* types) {
258 Code::Flags flags = Code::ComputeMonomorphicFlags(Code::STORE_IC); 260 Code::Flags flags = Code::ComputeMonomorphicFlags(Code::STORE_IC);
259 CollectReceiverTypes(expr->AssignmentFeedbackId(), name, flags, types); 261 CollectReceiverTypes(expr->AssignmentFeedbackId(), name, flags, types);
260 } 262 }
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 USE(maybe_result); 675 USE(maybe_result);
674 #ifdef DEBUG 676 #ifdef DEBUG
675 Object* result = NULL; 677 Object* result = NULL;
676 // Dictionary has been allocated with sufficient size for all elements. 678 // Dictionary has been allocated with sufficient size for all elements.
677 ASSERT(maybe_result->ToObject(&result)); 679 ASSERT(maybe_result->ToObject(&result));
678 ASSERT(*dictionary_ == result); 680 ASSERT(*dictionary_ == result);
679 #endif 681 #endif
680 } 682 }
681 683
682 } } // namespace v8::internal 684 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698