<webview>: Move back, forward, canGoBack, canGoForward, go from content to chrome

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <webview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
 var watchForTag = require('tagWatcher').watchForTag;
 var eventBindings = require('event_bindings');
 
 /** @type {Array.<string>} */
 var WEB_VIEW_ATTRIBUTES = ['name', 'src', 'partition', 'autosize', 'minheight',
     'minwidth', 'maxheight', 'maxwidth'];
 
 
 // All exposed api methods for <webview>, these are forwarded to the browser
 // plugin.
 var WEB_VIEW_API_METHODS = [
-  'back',
-  'canGoBack',
-  'canGoForward',
-  'forward',
   'getProcessId',
-  'go',
   'reload',
   'stop',
   'terminate'
 ];
 
 var WEB_VIEW_EVENTS = {
   'close': [],
   'consolemessage': ['level', 'message', 'line', 'sourceId'],
   'contentload' : [],
   'exit' : ['processId', 'reason'],
@@ skipping 86 matching lines @@
     self.browserPluginNode_.blur();
   });
 };
 
 /**
  * @private
  */
 WebView.prototype.setupWebviewNodeMethods_ = function() {
   // this.browserPluginNode_[apiMethod] are not necessarily defined immediately
   // after the shadow object is appended to the shadow root.
+  var webviewNode = this.webviewNode_;
+  var browserPluginNode = this.browserPluginNode_;
   var self = this;
+
+  webviewNode['canGoBack'] = function() {
+    return self.entryCount_ > 1 && self.currentEntryIndex_ > 0;

[lazyboy, 2013/06/22 04:29:15]

generally for member vars, declare them in prototype:

/** @type {number} */
WebView.prototype.entryCount_;

[Fady Samuel, 2013/06/25 15:46:12]

Done.

+  };
+
+  webviewNode['canGoForward'] = function() {
+    return self.currentEntryIndex_ >=0 &&
+        self.currentEntryIndex_ < (self.entryCount_ -1);

[lazyboy, 2013/06/22 04:29:15]

nit: space before 1

[Fady Samuel, 2013/06/25 15:46:12]

Done.

+  };
+
+  webviewNode['back'] = function() {
+    var instanceId = browserPluginNode.getGuestInstanceId();
+    if (!instanceId)
+      return;
+    chrome.webview.go(instanceId, -1);

[lazyboy, 2013/06/22 04:29:15]

nit: space before 1

[Fady Samuel, 2013/06/25 15:46:12]

Really? This is a unary operator, not a binary operator in this context. Leaving
as is.

[lazyboy, 2013/06/25 15:58:50]

I misread the line 0_0

+  };
+
+  webviewNode['forward'] = function() {
+    var instanceId = browserPluginNode.getGuestInstanceId();
+    if (!instanceId)
+      return;
+    chrome.webview.go(instanceId, 1);
+  };
+
+  webviewNode['go'] = function(relativeIndex) {
+    var instanceId = browserPluginNode.getGuestInstanceId();
+    if (!instanceId)
+      return;
+    chrome.webview.go(instanceId, relativeIndex);
+  };
+
   $Array.forEach(WEB_VIEW_API_METHODS, function(apiMethod) {
-    self.webviewNode_[apiMethod] = function(var_args) {
-      return self.browserPluginNode_[apiMethod].apply(
-          self.browserPluginNode_, arguments);
+    webviewNode[apiMethod] = function(var_args) {
+      return browserPluginNode[apiMethod].apply(browserPluginNode, arguments);
     };
   }, this);
   this.setupExecuteCodeAPI_();
 };
 
 /**
  * @private
  */
 WebView.prototype.setupWebviewNodeProperties_ = function() {
   var ERROR_MSG_CONTENTWINDOW_NOT_AVAILABLE = '<webview>: ' +
@@ skipping 105 matching lines @@
     if (newValue != oldValue) {
       this.webviewNode_.setAttribute(mutation.attributeName, newValue);
     }
   }
 };
 
 /**
  * @private
  */
 WebView.prototype.setupWebviewNodeEvents_ = function() {
+  var self = this;
   var webviewNode = this.webviewNode_;
   // TODO(fsamuel): Generalize this further as we add more events.
   var onAttached = function(e) {
     var detail = e.detail ? JSON.parse(e.detail) : {};
     loadCommitEvent.addListener(function(event) {
       var webviewEvent = new Event('loadcommit', {bubbles: true});
       var attribs = WEB_VIEW_EVENTS['loadcommit'];
       $Array.forEach(attribs, function(attribName) {
         webviewEvent[attribName] = event[attribName];
       });
+      self.currentEntryIndex_ = event.currentEntryIndex;
+      self.entryCount_ = event.entryCount;
       webviewNode.dispatchEvent(webviewEvent);
     }, {instanceId: detail.windowId});
   };
   this.browserPluginNode_.addEventListener('-internal-attached', onAttached);
 
   for (var eventName in WEB_VIEW_EVENTS) {
     this.setupEvent_(eventName, WEB_VIEW_EVENTS[eventName]);
   }
   this.setupNewWindowEvent_();
   this.setupPermissionEvent_();
@@ skipping 212 matching lines @@
   return [];
 };
 
 /**
  * Implemented when the experimental API is available.
  * @private
  */
 WebView.prototype.maybeSetupExperimentalAPI_ = function() {};
 
 exports.WebView = WebView;