Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: content/browser/renderer_host/media/media_stream_manager_unittest.cc

Issue 17444005: Remove MediaStreamDeviceThread in favor of using AudioThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix one more test. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/run_loop.h"
9 #include "content/browser/browser_thread_impl.h" 10 #include "content/browser/browser_thread_impl.h"
10 #include "content/browser/renderer_host/media/media_stream_manager.h" 11 #include "content/browser/renderer_host/media/media_stream_manager.h"
11 #include "content/browser/renderer_host/media/media_stream_ui_proxy.h" 12 #include "content/browser/renderer_host/media/media_stream_ui_proxy.h"
12 #include "content/common/media/media_stream_options.h" 13 #include "content/common/media/media_stream_options.h"
14 #include "content/public/test/test_browser_thread_bundle.h"
13 #include "media/audio/audio_manager_base.h" 15 #include "media/audio/audio_manager_base.h"
14 #if defined(OS_ANDROID) 16 #if defined(OS_ANDROID)
15 #include "media/audio/android/audio_manager_android.h" 17 #include "media/audio/android/audio_manager_android.h"
16 #elif defined(OS_LINUX) || defined(OS_OPENBSD) 18 #elif defined(OS_LINUX) || defined(OS_OPENBSD)
17 #include "media/audio/linux/audio_manager_linux.h" 19 #include "media/audio/linux/audio_manager_linux.h"
18 #elif defined(OS_MACOSX) 20 #elif defined(OS_MACOSX)
19 #include "media/audio/mac/audio_manager_mac.h" 21 #include "media/audio/mac/audio_manager_mac.h"
20 #elif defined(OS_WIN) 22 #elif defined(OS_WIN)
21 #include "media/audio/win/audio_manager_win.h" 23 #include "media/audio/win/audio_manager_win.h"
22 #endif 24 #endif
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 "fake_device_id")); 57 "fake_device_id"));
56 } 58 }
57 } 59 }
58 60
59 private: 61 private:
60 DISALLOW_COPY_AND_ASSIGN(MockAudioManager); 62 DISALLOW_COPY_AND_ASSIGN(MockAudioManager);
61 }; 63 };
62 64
63 class MediaStreamManagerTest : public ::testing::Test { 65 class MediaStreamManagerTest : public ::testing::Test {
64 public: 66 public:
65 MediaStreamManagerTest() {} 67 MediaStreamManagerTest()
66 68 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
67 MOCK_METHOD1(Response, void(int index)); 69 message_loop_(base::MessageLoopProxy::current()) {
68 void ResponseCallback(int index,
69 const MediaStreamDevices& devices,
70 scoped_ptr<MediaStreamUIProxy> ui_proxy) {
71 Response(index);
72 message_loop_->PostTask(FROM_HERE, base::MessageLoop::QuitClosure());
73 }
74
75 void WaitForResult() { message_loop_->Run(); }
76
77 protected:
78 virtual void SetUp() {
79 message_loop_.reset(new base::MessageLoop(base::MessageLoop::TYPE_IO));
80 ui_thread_.reset(new BrowserThreadImpl(BrowserThread::UI,
81 message_loop_.get()));
82 io_thread_.reset(new BrowserThreadImpl(BrowserThread::IO,
83 message_loop_.get()));
84
85 // Create our own MediaStreamManager. 70 // Create our own MediaStreamManager.
86 audio_manager_.reset(new MockAudioManager()); 71 audio_manager_.reset(new MockAudioManager());
87 media_stream_manager_.reset(new MediaStreamManager(audio_manager_.get())); 72 media_stream_manager_.reset(new MediaStreamManager(audio_manager_.get()));
88 73
89 // Use fake devices in order to run on the bots. 74 // Use fake devices in order to run on the bots.
90 media_stream_manager_->UseFakeDevice(); 75 media_stream_manager_->UseFakeDevice();
91 } 76 }
92 77
93 virtual void TearDown() { 78 virtual ~MediaStreamManagerTest() {}
94 message_loop_->RunUntilIdle();
95 79
96 // Delete the IO message loop to clean up the MediaStreamManager. 80 MOCK_METHOD1(Response, void(int index));
97 message_loop_.reset(); 81 void ResponseCallback(int index,
82 const MediaStreamDevices& devices,
83 scoped_ptr<MediaStreamUIProxy> ui_proxy) {
84 Response(index);
85 message_loop_->PostTask(FROM_HERE, run_loop_.QuitClosure());
98 } 86 }
99 87
88 protected:
100 std::string MakeMediaAccessRequest(int index) { 89 std::string MakeMediaAccessRequest(int index) {
101 const int render_process_id = 1; 90 const int render_process_id = 1;
102 const int render_view_id = 1; 91 const int render_view_id = 1;
103 StreamOptions components(MEDIA_DEVICE_AUDIO_CAPTURE, 92 StreamOptions components(MEDIA_DEVICE_AUDIO_CAPTURE,
104 MEDIA_DEVICE_VIDEO_CAPTURE); 93 MEDIA_DEVICE_VIDEO_CAPTURE);
105 const GURL security_origin; 94 const GURL security_origin;
106 MediaStreamManager::MediaRequestResponseCallback callback = 95 MediaStreamManager::MediaRequestResponseCallback callback =
107 base::Bind(&MediaStreamManagerTest::ResponseCallback, 96 base::Bind(&MediaStreamManagerTest::ResponseCallback,
108 base::Unretained(this), index); 97 base::Unretained(this), index);
109 return media_stream_manager_->MakeMediaAccessRequest(render_process_id, 98 return media_stream_manager_->MakeMediaAccessRequest(render_process_id,
110 render_view_id, 99 render_view_id,
111 components, 100 components,
112 security_origin, 101 security_origin,
113 callback); 102 callback);
114 } 103 }
115 104
116 scoped_ptr<base::MessageLoop> message_loop_;
117 scoped_ptr<BrowserThreadImpl> ui_thread_;
118 scoped_ptr<BrowserThreadImpl> io_thread_;
119 scoped_ptr<media::AudioManager> audio_manager_; 105 scoped_ptr<media::AudioManager> audio_manager_;
120 scoped_ptr<MediaStreamManager> media_stream_manager_; 106 scoped_ptr<MediaStreamManager> media_stream_manager_;
107 content::TestBrowserThreadBundle thread_bundle_;
108 scoped_refptr<base::MessageLoopProxy> message_loop_;
109 base::RunLoop run_loop_;
121 110
122 private: 111 private:
123 DISALLOW_COPY_AND_ASSIGN(MediaStreamManagerTest); 112 DISALLOW_COPY_AND_ASSIGN(MediaStreamManagerTest);
124 }; 113 };
125 114
126 TEST_F(MediaStreamManagerTest, MakeMediaAccessRequest) { 115 TEST_F(MediaStreamManagerTest, MakeMediaAccessRequest) {
127 MakeMediaAccessRequest(0); 116 MakeMediaAccessRequest(0);
128 117
129 // Expecting the callback will be triggered and quit the test. 118 // Expecting the callback will be triggered and quit the test.
130 EXPECT_CALL(*this, Response(0)); 119 EXPECT_CALL(*this, Response(0));
131 WaitForResult(); 120 run_loop_.Run();
132 } 121 }
133 122
134 TEST_F(MediaStreamManagerTest, MakeAndCancelMediaAccessRequest) { 123 TEST_F(MediaStreamManagerTest, MakeAndCancelMediaAccessRequest) {
135 std::string label = MakeMediaAccessRequest(0); 124 std::string label = MakeMediaAccessRequest(0);
136 // No callback is expected. 125 // No callback is expected.
137 media_stream_manager_->CancelRequest(label); 126 media_stream_manager_->CancelRequest(label);
138 } 127 }
139 128
140 TEST_F(MediaStreamManagerTest, MakeMultipleRequests) { 129 TEST_F(MediaStreamManagerTest, MakeMultipleRequests) {
141 // First request. 130 // First request.
(...skipping 13 matching lines...) Expand all
155 render_view_id, 144 render_view_id,
156 components, 145 components,
157 security_origin, 146 security_origin,
158 callback); 147 callback);
159 148
160 // Expecting the callbackS from requests will be triggered and quit the test. 149 // Expecting the callbackS from requests will be triggered and quit the test.
161 // Note, the callbacks might come in a different order depending on the 150 // Note, the callbacks might come in a different order depending on the
162 // value of labels. 151 // value of labels.
163 EXPECT_CALL(*this, Response(0)); 152 EXPECT_CALL(*this, Response(0));
164 EXPECT_CALL(*this, Response(1)); 153 EXPECT_CALL(*this, Response(1));
165 WaitForResult(); 154 run_loop_.Run();
166 } 155 }
167 156
168 TEST_F(MediaStreamManagerTest, MakeAndCancelMultipleRequests) { 157 TEST_F(MediaStreamManagerTest, MakeAndCancelMultipleRequests) {
169 std::string label1 = MakeMediaAccessRequest(0); 158 std::string label1 = MakeMediaAccessRequest(0);
170 std::string label2 = MakeMediaAccessRequest(1); 159 std::string label2 = MakeMediaAccessRequest(1);
171 media_stream_manager_->CancelRequest(label1); 160 media_stream_manager_->CancelRequest(label1);
172 161
173 // Expecting the callback from the second request will be triggered and 162 // Expecting the callback from the second request will be triggered and
174 // quit the test. 163 // quit the test.
175 EXPECT_CALL(*this, Response(1)); 164 EXPECT_CALL(*this, Response(1));
176 WaitForResult(); 165 run_loop_.Run();
177 } 166 }
178 167
179 } // namespace content 168 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698