Fix the problem that wrong context menu shows up when right clicking a link on Mac

Fix the problem that wrong context menu shows up when right clicking a link on Mac

This occurs because right-clicking a link on Mac also selects it. We need to check for link before selection.

BUG=249546
TEST=Manual test by creating a panel and right clicking on a link

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207731

[jianli, 2013-06-19 00:26:31]

Brett, could you please also approve it?

[Dmitry Titov, 2013-06-19 01:14:41]

https://codereview.chromium.org/17440004/diff/1/chrome/browser/tab_contents/r...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

https://codereview.chromium.org/17440004/diff/1/chrome/browser/tab_contents/r...
chrome/browser/tab_contents/render_view_context_menu.cc:733: else if
(has_selection)
why have an 'else' here? On normal pages we show both Link items and "Copy"...

[jianli, 2013-06-19 17:08:18]

https://codereview.chromium.org/17440004/diff/1/chrome/browser/tab_contents/r...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

https://codereview.chromium.org/17440004/diff/1/chrome/browser/tab_contents/r...
chrome/browser/tab_contents/render_view_context_menu.cc:733: else if
(has_selection)
On 2013/06/19 01:14:41, Dmitry Titov wrote:
> why have an 'else' here? On normal pages we show both Link items and "Copy"...

Changed to allow both link and copy.

[Dmitry Titov, 2013-06-19 17:46:14]

lgtm

[jianli, 2013-06-19 20:52:38]

Brettw, could you please approve the patch as an owner? Thanks.

[brettw, 2013-06-20 19:31:27]

lgtm

[commit-bot: I haz the power, 2013-06-20 19:33:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/17440004/22001

[commit-bot: I haz the power, 2013-06-21 06:12:24]

Change committed as 207731