Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 17438004: [Android] Clear adb logcat during adb_logcat_monitor startup. (Closed)

Created:
7 years, 6 months ago by frankf
Modified:
7 years, 6 months ago
Reviewers:
Yaron, Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Clear adb logcat during adb_logcat_monitor startup. BUG=249039 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207175

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/adb_logcat_monitor.py View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
frankf
7 years, 6 months ago (2013-06-18 23:51:34 UTC) #1
Isaac (away)
Not sure why you didn't add me to reviewer... Here's a drive by. https://codereview.chromium.org/17438004/diff/1/build/android/adb_logcat_monitor.py File ...
7 years, 6 months ago (2013-06-19 00:10:33 UTC) #2
frankf
https://codereview.chromium.org/17438004/diff/1/build/android/adb_logcat_monitor.py File build/android/adb_logcat_monitor.py (right): https://codereview.chromium.org/17438004/diff/1/build/android/adb_logcat_monitor.py#newcode129 build/android/adb_logcat_monitor.py:129: subprocess.call([adb_cmd, '-s', device_id, 'logcat', '-c']) No, this is the ...
7 years, 6 months ago (2013-06-19 00:18:54 UTC) #3
Isaac (away)
lgtm
7 years, 6 months ago (2013-06-19 00:29:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/17438004/1
7 years, 6 months ago (2013-06-19 02:07:29 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 04:06:33 UTC) #6
Message was sent while issue was closed.
Change committed as 207175

Powered by Google App Engine
This is Rietveld 408576698