Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tools/telemetry/telemetry/page/page_measurement.py

Issue 17438002: [telemetry] test_runner and run_benchmarks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_measurement.py
diff --git a/tools/telemetry/telemetry/page/page_measurement.py b/tools/telemetry/telemetry/page/page_measurement.py
index d81c79e35ae9dfd4de9b83570585ef2ca9a2ee3b..50e59d28a2432d0222776c3e19841ba7afce4689 100644
--- a/tools/telemetry/telemetry/page/page_measurement.py
+++ b/tools/telemetry/telemetry/page/page_measurement.py
@@ -70,16 +70,19 @@ class PageMeasurement(page_test.PageTest):
return ['buildbot', 'block', 'csv', 'none']
def PrepareResults(self, options):
- if not options.output_file or options.output_file == '-':
- output_stream = sys.stdout
- else:
+ if hasattr(options, 'output_file') and options.output_file:
output_stream = open(os.path.expanduser(options.output_file), 'w')
+ else:
+ output_stream = sys.stdout
+ if not hasattr(options, 'output_format'):
+ options.output_format = self.output_format_choices[0]
+ if not hasattr(options, 'output_trace_tag'):
+ options.output_trace_tag = ''
if options.output_format == 'csv':
return csv_page_measurement_results.CsvPageMeasurementResults(
output_stream,
- self.results_are_the_same_on_every_page,
- trace_tag=options.output_trace_tag)
+ self.results_are_the_same_on_every_page)
elif options.output_format == 'block':
return block_page_measurement_results.BlockPageMeasurementResults(
output_stream)

Powered by Google App Engine
This is Rietveld 408576698