Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 17432002: Replace content::ContextMenuSourceType with ui::MenuSourceType. (Closed)

Created:
7 years, 6 months ago by varunjain
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, tfarina, jam, jochen+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Replace content::ContextMenuSourceType with ui::MenuSourceType. BUG=239110 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -65 lines) Patch
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 chunk +6 lines, -23 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/view_messages.h View 4 chunks +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/port/browser/render_view_host_delegate_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/web_contents_view_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/context_menu_params.h View 2 chunks +2 lines, -2 lines 0 comments Download
D content/public/common/context_menu_source_type.h View 1 chunk +0 lines, -22 lines 0 comments Download
M content/renderer/render_view_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/shell/shell_web_contents_view_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
varunjain
sky@ -> content/browser/* kenrb@ -> view_messages.h avi@ -> content/renderer/*
7 years, 6 months ago (2013-06-18 22:16:09 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-19 00:25:45 UTC) #2
Avi (use Gerrit)
lgtm stampity stamp
7 years, 6 months ago (2013-06-21 19:23:18 UTC) #3
palmer
Rubberstamp goes *ker-chunk* LGTM
7 years, 6 months ago (2013-06-21 19:27:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/17432002/1
7 years, 6 months ago (2013-06-21 19:29:28 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 22:53:07 UTC) #6
Message was sent while issue was closed.
Change committed as 207946

Powered by Google App Engine
This is Rietveld 408576698