Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Issue 17428004: [chromedriver] Fix error due to remove of chrome/test/pylib/common. (Closed)

Created:
7 years, 6 months ago by chrisgao (Use stgao instead)
Modified:
7 years, 6 months ago
Reviewers:
craigdh
CC:
chromium-reviews, kkania, frankf
Visibility:
Public.

Description

[chromedriver] Fix error due to remove of chrome/test/pylib/common. Also fix some pylint warnings. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M chrome/test/chromedriver/archive.py View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/test/chromedriver/test_environment.py View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chrisgao (Use stgao instead)
This CL is to fix error in chromedriver waterfall.
7 years, 6 months ago (2013-06-21 19:06:43 UTC) #1
craigdh
lgtm
7 years, 6 months ago (2013-06-21 19:11:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/17428004/1
7 years, 6 months ago (2013-06-21 19:18:29 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 19:25:38 UTC) #4
Message was sent while issue was closed.
Change committed as 207900

Powered by Google App Engine
This is Rietveld 408576698