Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 17424004: Added test to verify that onmostvisitedchange event is dispatched when an user navigate from SRP to… (Closed)

Created:
7 years, 6 months ago by kmadhusu
Modified:
7 years, 6 months ago
Reviewers:
Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Visibility:
Public.

Description

Added test to verify that onmostvisitedchange event is dispatched when an user navigate from SRP to NTP. Added InstantExtendedTest.DispatchMVChangeEventWhileNavigatingBackToNTP. BUG=248683 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208109

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M chrome/browser/ui/search/instant_controller.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kmadhusu
Follow up of crrev.com/16780007. PTAL. Thanks.
7 years, 6 months ago (2013-06-18 21:32:40 UTC) #1
Jered
https://codereview.chromium.org/17424004/diff/9001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc File chrome/browser/ui/search/instant_extended_interactive_uitest.cc (right): https://codereview.chromium.org/17424004/diff/9001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc#newcode2901 chrome/browser/ui/search/instant_extended_interactive_uitest.cc:2901: // Flaky on Windows and Mac try bots. What ...
7 years, 6 months ago (2013-06-19 22:26:44 UTC) #2
kmadhusu
This CL depends on https://codereview.chromium.org/17521002/. Thanks. https://codereview.chromium.org/17424004/diff/9001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc File chrome/browser/ui/search/instant_extended_interactive_uitest.cc (right): https://codereview.chromium.org/17424004/diff/9001/chrome/browser/ui/search/instant_extended_interactive_uitest.cc#newcode2901 chrome/browser/ui/search/instant_extended_interactive_uitest.cc:2901: // Flaky on ...
7 years, 6 months ago (2013-06-21 17:34:54 UTC) #3
Jered
On 2013/06/21 17:34:54, kmadhusu wrote: > This CL depends on https://codereview.chromium.org/17521002/. > > Thanks. > ...
7 years, 6 months ago (2013-06-21 18:01:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17424004/34003
7 years, 6 months ago (2013-06-22 21:09:05 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-22 22:38:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/17424004/34003
7 years, 6 months ago (2013-06-23 01:16:55 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-23 04:22:27 UTC) #8
Message was sent while issue was closed.
Change committed as 208109

Powered by Google App Engine
This is Rietveld 408576698