Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17419008: Move PPB_NetAddress out of dev. (Closed)

Created:
7 years, 6 months ago by yzshen1
Modified:
7 years, 6 months ago
Reviewers:
bbudge, binji
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, yzshen+watch_chromium.org, darin-cc_chromium.org, Sam Clegg, piman+watch_chromium.org, binji, ihf+watch_chromium.org, dmichael (off chromium)
Visibility:
Public.

Description

Move PPB_NetAddress out of dev. BUG=247225 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208080

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -1065 lines) Patch
M native_client_sdk/src/build_tools/sdk_files.list View 1 2 3 5 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 2 3 4 chunks +2 lines, -2 lines 0 comments Download
M ppapi/api/dev/ppb_host_resolver_dev.idl View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
D ppapi/api/dev/ppb_net_address_dev.idl View 1 2 3 4 1 chunk +0 lines, -169 lines 0 comments Download
M ppapi/api/dev/ppb_tcp_socket_dev.idl View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/api/dev/ppb_udp_socket_dev.idl View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
A + ppapi/api/ppb_net_address.idl View 1 2 3 4 8 chunks +25 lines, -25 lines 0 comments Download
M ppapi/c/dev/ppb_host_resolver_dev.h View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
D ppapi/c/dev/ppb_net_address_dev.h View 1 2 3 4 1 chunk +0 lines, -203 lines 0 comments Download
M ppapi/c/dev/ppb_tcp_socket_dev.h View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/c/dev/ppb_udp_socket_dev.h View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
A + ppapi/c/ppb_net_address.h View 1 2 3 4 11 chunks +34 lines, -34 lines 0 comments Download
M ppapi/cpp/dev/host_resolver_dev.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/cpp/dev/host_resolver_dev.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D ppapi/cpp/dev/net_address_dev.h View 1 2 3 4 1 chunk +0 lines, -114 lines 0 comments Download
D ppapi/cpp/dev/net_address_dev.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M ppapi/cpp/dev/tcp_socket_dev.h View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M ppapi/cpp/dev/tcp_socket_dev.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ppapi/cpp/dev/udp_socket_dev.h View 1 2 3 4 5 chunks +9 lines, -9 lines 0 comments Download
M ppapi/cpp/dev/udp_socket_dev.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + ppapi/cpp/net_address.h View 1 2 3 4 5 4 chunks +36 lines, -36 lines 0 comments Download
A ppapi/cpp/net_address.cc View 1 1 chunk +99 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 4 12 chunks +58 lines, -58 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_sources.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/proxy/net_address_resource.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/net_address_resource.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/tests/all_cpp_includes.h View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/tests/test_host_resolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_host_resolver.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/tests/test_net_address.cc View 5 chunks +25 lines, -26 lines 0 comments Download
M ppapi/tests/test_tcp_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_tcp_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_udp_socket.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ppapi/tests/test_udp_socket.cc View 10 chunks +28 lines, -28 lines 0 comments Download
M ppapi/tests/test_utils.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ppapi/tests/test_utils.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_net_address_api.h View 2 chunks +4 lines, -4 lines 0 comments Download
D ppapi/thunk/ppb_net_address_dev_thunk.cc View 1 chunk +0 lines, -98 lines 0 comments Download
A + ppapi/thunk/ppb_net_address_thunk.cc View 1 8 chunks +18 lines, -18 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/common/plugins/ppapi/ppapi_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yzshen1
Hi, Bill. Would you please take a look at it? Please note that this CL ...
7 years, 6 months ago (2013-06-20 18:58:23 UTC) #1
bbudge
Bump version and 1 nit. LGTM https://codereview.chromium.org/17419008/diff/1/ppapi/api/ppb_net_address.idl File ppapi/api/ppb_net_address.idl (right): https://codereview.chromium.org/17419008/diff/1/ppapi/api/ppb_net_address.idl#newcode11 ppapi/api/ppb_net_address.idl:11: M29 = 0.1 ...
7 years, 6 months ago (2013-06-20 19:25:01 UTC) #2
yzshen1
Thanks a lot Bill! https://chromiumcodereview.appspot.com/17419008/diff/1/ppapi/api/ppb_net_address.idl File ppapi/api/ppb_net_address.idl (right): https://chromiumcodereview.appspot.com/17419008/diff/1/ppapi/api/ppb_net_address.idl#newcode11 ppapi/api/ppb_net_address.idl:11: M29 = 0.1 On 2013/06/20 ...
7 years, 6 months ago (2013-06-20 20:54:12 UTC) #3
yzshen1
Hi, Ben. Please take a look at files in native_client_sdk/. Thanks!
7 years, 6 months ago (2013-06-21 18:53:32 UTC) #4
binji
native_client_sdk lgtm
7 years, 6 months ago (2013-06-21 19:13:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/17419008/39004
7 years, 6 months ago (2013-06-22 17:55:20 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 20:07:56 UTC) #7
Message was sent while issue was closed. 
Change committed as 208080

Powered by Google App Engine
This is Rietveld 408576698