Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: chrome/browser/history/history_database.cc

Issue 17416002: Reduce the HistoryDatabase's page cache from 6000 (24MB) to 1000 (4MB) pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_database.cc
diff --git a/chrome/browser/history/history_database.cc b/chrome/browser/history/history_database.cc
index 9be2f15bf4daca7aef5bcc68d5b569237dc23258..782bdfcdb4799e3d6cadd5aa54dd8c750cfe1ef8 100644
--- a/chrome/browser/history/history_database.cc
+++ b/chrome/browser/history/history_database.cc
@@ -56,11 +56,11 @@ sql::InitStatus HistoryDatabase::Init(const base::FilePath& history_name) {
// this is a NOP. Must be a power of 2 and a max of 8192.
db_.set_page_size(4096);
- // Increase the cache size. The page size, plus a little extra, times this
+ // Set the cache size. The page size, plus a little extra, times this
// value, tells us how much memory the cache will use maximum.
- // 6000 * 4MB = 24MB
+ // 1000 * 4kB = 4MB
// TODO(brettw) scale this value to the amount of available memory.
- db_.set_cache_size(6000);
+ db_.set_cache_size(1000);
// Note that we don't set exclusive locking here. That's done by
// BeginExclusiveMode below which is called later (we have to be in shared
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698