Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: tests/skia_test.cpp

Issue 17414003: Refactor: clean up some unused or mostly-unused API I saw here. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: bungeman Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/Test.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/skia_test.cpp
diff --git a/tests/skia_test.cpp b/tests/skia_test.cpp
index 8cae6560893fcd6224f8bb5541a25d1db708983f..98168c55dd86da3c4f27285a62eebf322e36a3e3 100644
--- a/tests/skia_test.cpp
+++ b/tests/skia_test.cpp
@@ -55,10 +55,6 @@ private:
const TestRegistry* fReg;
};
-static const char* result2string(Reporter::Result result) {
- return result == Reporter::kPassed ? "passed" : "FAILED";
-}
-
class DebugfReporter : public Reporter {
public:
DebugfReporter(bool allowExtendedTest, bool allowThreaded)
@@ -87,8 +83,8 @@ protected:
sk_atomic_inc(&fPending);
SkDebugf("[%3d/%3d] (%d) %s\n", index+1, fTotal, fPending, test->getName());
}
- virtual void onReport(const char desc[], Reporter::Result result) {
- SkDebugf("\t%s: %s\n", result2string(result), desc);
+ virtual void onReportFailed(const SkString& desc) {
+ SkDebugf("\tFAILED: %s\n", desc.c_str());
}
virtual void onEnd(Test* test) {
« no previous file with comments | « tests/Test.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698