Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: tests/Test.h

Issue 17414003: Refactor: clean up some unused or mostly-unused API I saw here. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: bungeman Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/StreamTest.cpp ('k') | tests/Test.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/Test.h
diff --git a/tests/Test.h b/tests/Test.h
index 8cb23c1b48b2728a83cb582621f54845f6705700..fa62afeab3b4b0b6e40ac968163ae76474f9f310 100644
--- a/tests/Test.h
+++ b/tests/Test.h
@@ -25,35 +25,19 @@ namespace skiatest {
SK_DECLARE_INST_COUNT(Reporter)
Reporter();
- enum Result {
- kPassed, // must begin with 0
- kFailed,
- /////
- kLastResult = kFailed
- };
-
int countTests() const { return fTestCount; }
void startTest(Test*);
- void report(const char testDesc[], Result);
+ void reportFailed(const SkString& desc);
void endTest(Test*);
virtual bool allowExtendedTest() const { return false; }
virtual bool allowThreaded() const { return false; }
virtual void bumpTestCount() { sk_atomic_inc(&fTestCount); }
- // helpers for tests
- void reportFailed(const char desc[]) {
- this->report(desc, kFailed);
- }
- void reportFailed(const SkString& desc) {
- this->report(desc.c_str(), kFailed);
- }
-
-
protected:
virtual void onStart(Test*) {}
- virtual void onReport(const char desc[], Result) {}
+ virtual void onReportFailed(const SkString& desc) {}
virtual void onEnd(Test*) {}
private:
« no previous file with comments | « tests/StreamTest.cpp ('k') | tests/Test.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698