Refactor: clean up some unused or mostly-unused API I saw here.

tests/DataRefTest.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "Test.h"
 #include "SkData.h"
 #include "SkDataSet.h"
@@ skipping 255 matching lines @@
     }
 
     SkString path = SkOSPath::SkPathJoin(tmpDir.c_str(), "data_test");
 
     const char s[] = "abcdefghijklmnopqrstuvwxyz";
     {
         SkFILEWStream writer(path.c_str());
         if (!writer.isValid()) {
             SkString msg;
             msg.printf("Failed to create tmp file %s\n", path.c_str());
-            reporter->reportFailed(msg.c_str());
+            reporter->reportFailed(msg);
             return;
         }
         writer.write(s, 26);
     }
 
     SkFILE* file = sk_fopen(path.c_str(), kRead_SkFILE_Flag);
     SkAutoTUnref<SkData> r1(SkData::NewFromFILE(file));
     REPORTER_ASSERT(reporter, r1.get() != NULL);
     REPORTER_ASSERT(reporter, r1->size() == 26);
     REPORTER_ASSERT(reporter, strncmp(static_cast<const char*>(r1->data()), s, 26) == 0);
@@ skipping 31 matching lines @@
     tmp->unref();
 
     test_cstring(reporter);
     test_dataset(reporter);
     test_files(reporter);
 }
 
 #include "TestClassDef.h"
 DEFINE_TESTCLASS("Data", DataTestClass, TestData)
 DEFINE_TESTCLASS("DataTable", DataTableTestClass, TestDataTable)