Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 17413017: InstantExtended: Don't create overlay. (Closed)

Created:
7 years, 6 months ago by Jered
Modified:
7 years, 6 months ago
Reviewers:
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Visibility:
Public.

Description

InstantExtended: Don't create overlay. We do not desire to create an overlay that we never use. BUG=247717 TBR=samarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -1766 lines) Patch
M chrome/browser/ui/search/instant_controller.h View 2 chunks +3 lines, -37 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 10 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 40 chunks +140 lines, -1650 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 3 chunks +13 lines, -44 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 1 chunk +1 line, -15 lines 0 comments Download
M chrome/browser/ui/search/local_ntp_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/17413017/1
7 years, 6 months ago (2013-06-21 15:39:13 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 19:11:55 UTC) #2
Message was sent while issue was closed.
Change committed as 207893

Powered by Google App Engine
This is Rietveld 408576698