Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 17413011: Remove surface.gyp from command_buffer_service.gypi (Closed)

Created:
7 years, 6 months ago by danakj
Modified:
7 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, apatrick_chromium, backer
Visibility:
Public.

Description

Remove surface.gyp from command_buffer_service.gypi This dependency is no longer used or needed since io_surface_support_mac has moved to ui/gl/ in https://codereview.chromium.org/17381009/. This could have been done there but was missed. R=piman BUG=179729 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207408

Patch Set 1 #

Patch Set 2 : surface.gyp: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gpu/command_buffer_service.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 6 months ago (2013-06-19 02:00:39 UTC) #1
danakj
Hmm.. can't reproduce these failures locally. I'll have to look at them some more tomorrow.
7 years, 6 months ago (2013-06-19 02:41:32 UTC) #2
danakj
On 2013/06/19 02:41:32, danakj wrote: > Hmm.. can't reproduce these failures locally. I'll have to ...
7 years, 6 months ago (2013-06-19 03:26:21 UTC) #3
piman
lgtm
7 years, 6 months ago (2013-06-19 18:07:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/17413011/10001
7 years, 6 months ago (2013-06-19 18:13:35 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 13:22:25 UTC) #6
Message was sent while issue was closed.
Change committed as 207408

Powered by Google App Engine
This is Rietveld 408576698