Replace PresentationIdleDelayScale with PresentationScreenDimDelayScale

Replace PresentationIdleDelayScale with PresentationScreenDimDelayScale

Presentation mode used to lengthen the idle delay. It now lengthens the
screen dim delay instead. This CL adds a policy that controls the
scaling of the screen dim delay and deprecates the policy that used to
control the scaling of the idle delay.

BUG=248940
TEST=Updated browser and unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208035

[bartfab (slow), 2013-06-21 00:45:49]

Hi Mattias,

Could you please review?

[bartfab (slow), 2013-06-21 18:20:30]

Hi Joao,

Could you take a look?

[Joao da Silva, 2013-06-21 19:14:45]

lgtm

[commit-bot: I haz the power, 2013-06-21 19:29:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/19001

[bartfab (slow), 2013-06-21 19:33:21]

Hi Daniel,

This CL removes an obsolete pref. Could you do an owner review of
chrome/browser/chromeos/preferences.cc?

[bartfab (slow), 2013-06-21 19:34:09]

Hi Daniel,

This CL removes an obsolete pref. Could you do an owner review of
chrome/browser/chromeos/preferences.cc?

[Daniel Erat, 2013-06-21 20:13:32]

lgtm

https://codereview.chromium.org/17408010/diff/19001/chrome/test/data/policy/p...
File chrome/test/data/policy/policy_test_cases.json (right):

https://codereview.chromium.org/17408010/diff/19001/chrome/test/data/policy/p...
chrome/test/data/policy/policy_test_cases.json:1698:
"PresentationIdleDelayScale": {
can this be removed now or does it need to stay?

[bartfab (slow), 2013-06-21 20:58:25]

https://codereview.chromium.org/17408010/diff/19001/chrome/test/data/policy/p...
File chrome/test/data/policy/policy_test_cases.json (right):

https://codereview.chromium.org/17408010/diff/19001/chrome/test/data/policy/p...
chrome/test/data/policy/policy_test_cases.json:1698:
"PresentationIdleDelayScale": {
It needs to stay. The policy is still listed in policy_templates.json (and will
remain there for future reference). We have a test that verifies every policy
listed in policy_templates.json has an entry in policy_test_cases.json.

[commit-bot: I haz the power, 2013-06-21 20:58:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/19001

[commit-bot: I haz the power, 2013-06-22 02:20:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/9004

[commit-bot: I haz the power, 2013-06-22 02:41:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/9004

[commit-bot: I haz the power, 2013-06-22 03:06:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/9004

[commit-bot: I haz the power, 2013-06-22 03:20:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/9004

[commit-bot: I haz the power, 2013-06-22 03:34:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/9004

[commit-bot: I haz the power, 2013-06-22 03:42:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/17408010/9004

[commit-bot: I haz the power, 2013-06-22 14:21:41]

Change committed as 208035