Issue 17408009: Fix bug preventing supervised users from changing proxy settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17408009: Fix bug preventing supervised users from changing proxy settings. (Closed)

Created:
7 years, 6 months ago by Pam (message me for reviews)

Modified:
7 years, 6 months ago

Reviewers:
Adrian Kuegel

CC:
chromium-reviews, dbeam+watch-options_chromium.org, csilv

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix bug preventing supervised users from changing proxy settings. The change in r185359 added the pref for allowing signin to the the pref registrar previously used only for proxy settings. (Other prefs have since been added on too.) This, in combination with the use of the registrar's IsManaged() method rather than the pref's own IsManaged() -- or better still, using IsUserModifiable() for the best semantic fit -- meant that once supervised users had signin disabled, they also had proxy changes disabled. This fix changes the condition to use Preference::IsUserModifiable(). BUG=252426 TEST=create a supervised user; make sure the "Change proxy settings..." button is enabled Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207851