Issue 17408002: remove double including of libpng decoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17408002: remove double including of libpng decoder (Closed)

Created:
7 years, 6 months ago by Zach Reizner

Modified:
7 years, 6 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove double including of libpng decoder

Patch Set 1 #

Patch Set 2 : add force linking to gm #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	gm/gmmain.cpp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
	M	gyp/images.gyp	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Zach Reizner

Turns out I need this patch to build libskia.so, even without building lua.

7 years, 6 months ago (2013-06-18 15:23:21 UTC) #1

bungeman-skia

On 2013/06/18 15:23:21, Zach Reizner wrote: > Turns out I need this patch to build ...

7 years, 6 months ago (2013-06-18 15:43:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/zachr@google.com/17408002/5001

7 years, 6 months ago (2013-06-18 19:57:44 UTC) #5

commit-bot: I haz the power

7 years, 6 months ago (2013-06-18 20:09:29 UTC) #6

Failed to apply the patch.
Sending        gm/gmmain.cpp
Sending        gyp/images.gyp
Transmitting file data ..svn: Commit failed (details follow):
svn: Commit failed unexpectedly --- please try again later (1)

Expand Messages | Collapse Messages