Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 17397003: Add the referrer url to the downloads table in the History database. (Closed)

Created:
7 years, 6 months ago by benjhayden
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, browser-components-watch_chromium.org
Visibility:
Public.

Description

Add the referrer url to the downloads table in the History database. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207933

Patch Set 1 #

Patch Set 2 : @r206768 #

Patch Set 3 : @r207869 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -27 lines) Patch
M chrome/browser/history/download_database.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/download_database.cc View 8 chunks +26 lines, -19 lines 0 comments Download
M chrome/browser/history/history_database.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 4 chunks +76 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benjhayden
PTAL
7 years, 6 months ago (2013-06-18 15:04:09 UTC) #1
sky
Can you also add a migration test?
7 years, 6 months ago (2013-06-18 17:44:50 UTC) #2
benjhayden
PTAL
7 years, 6 months ago (2013-06-18 21:29:20 UTC) #3
sky
LGTM
7 years, 6 months ago (2013-06-18 21:31:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/17397003/31001
7 years, 6 months ago (2013-06-21 19:51:35 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 22:12:55 UTC) #6
Message was sent while issue was closed.
Change committed as 207933

Powered by Google App Engine
This is Rietveld 408576698