components/offline_pages/offline_page_model.cc - Issue 1739503002: Makes the OfflinePageBridge.getAllPages method asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model.cc

Issue 1739503002: Makes the OfflinePageBridge.getAllPages method asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix broken test from rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java ('K') | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | components/offline_pages/offline_page_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model.cc

diff --git a/components/offline_pages/offline_page_model.cc b/components/offline_pages/offline_page_model.cc

index ac33771f4e1e6f9e8798ea6ed089d1a97f571719..580afe572b0dad07620fa5cac3a88bb59da8e1eb 100644

--- a/components/offline_pages/offline_page_model.cc

+++ b/components/offline_pages/offline_page_model.cc

@@ -226,15 +226,6 @@ void OfflinePageModel::MarkPageForDeletion(int64_t offline_id,

weak_ptr_factory_.GetWeakPtr(), offline_page_item, callback));

}

-void OfflinePageModel::DeletePageByOfflineId(

- int64_t offline_id,

- const DeletePageCallback& callback) {

- DCHECK(is_loaded_);

- std::vector<int64_t> offline_ids_to_delete;

- offline_ids_to_delete.push_back(offline_id);

- DeletePagesByOfflineId(offline_ids_to_delete, callback);

void OfflinePageModel::DeletePagesByOfflineId(

const std::vector<int64_t>& offline_ids,

const DeletePageCallback& callback) {