Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 17391004: Reland "Fix reload after back/forward navigation setting the wrong cache policy."" (Closed)

Created:
7 years, 6 months ago by Nate Chapin
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Reland "Fix reload after back/forward navigation setting the wrong cache policy."" This reverts commit c9cfbdff188ab7fc4c74a73c7f1e9e1010efde7d. BUG=248145 TEST=WebFrameTest.BackToReload Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152752

Patch Set 1 #

Patch Set 2 : With fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 1 1 chunk +26 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nate Chapin
7 years, 6 months ago (2013-06-18 18:17:33 UTC) #1
Nate Chapin
On 2013/06/18 18:17:33, Nate Chapin wrote: There was a spurious registerMockedHttpURLLoad() call that caused this ...
7 years, 6 months ago (2013-06-18 18:17:55 UTC) #2
abarth-chromium
On 2013/06/18 18:17:55, Nate Chapin wrote: > On 2013/06/18 18:17:33, Nate Chapin wrote: > > ...
7 years, 6 months ago (2013-06-19 16:47:26 UTC) #3
abarth-chromium
lgtm
7 years, 6 months ago (2013-06-19 16:47:29 UTC) #4
Nate Chapin
On 2013/06/19 16:47:26, abarth wrote: > On 2013/06/18 18:17:55, Nate Chapin wrote: > > On ...
7 years, 6 months ago (2013-06-19 16:48:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/17391004/2001
7 years, 6 months ago (2013-06-19 16:49:03 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-19 18:31:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/17391004/2001
7 years, 6 months ago (2013-06-19 18:33:42 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 05:51:20 UTC) #9
Message was sent while issue was closed.
Change committed as 152752

Powered by Google App Engine
This is Rietveld 408576698