Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: chrome/browser/translate/translate_language_list.cc

Issue 17390018: Refactoring: Create TranslateScript from TranslateManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactoring-translate-url-fetcher
Patch Set: Removed the nits Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/translate/translate_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_language_list.h" 5 #include "chrome/browser/translate/translate_language_list.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 const char kAlphaLanguageQueryValue[] = "1"; 104 const char kAlphaLanguageQueryValue[] = "1";
105 105
106 // Assign following IDs to URLFetchers so that tests can distinguish each 106 // Assign following IDs to URLFetchers so that tests can distinguish each
107 // request in order to simiulate respectively. 107 // request in order to simiulate respectively.
108 const int kFetcherIdForLanguageList = 1; 108 const int kFetcherIdForLanguageList = 1;
109 const int kFetcherIdForAlphaLanguageList = 2; 109 const int kFetcherIdForAlphaLanguageList = 2;
110 110
111 // Represent if the language list updater is disabled. 111 // Represent if the language list updater is disabled.
112 bool update_is_disabled = false; 112 bool update_is_disabled = false;
113 113
114 // Retry parameter for fetching.
115 const int kMaxRetryOn5xx = 5;
116
114 // Show a message in chrome:://translate-internals Event Logs. 117 // Show a message in chrome:://translate-internals Event Logs.
115 void NotifyEvent(int line, const std::string& message) { 118 void NotifyEvent(int line, const std::string& message) {
116 TranslateManager* manager = TranslateManager::GetInstance(); 119 TranslateManager* manager = TranslateManager::GetInstance();
117 DCHECK(manager); 120 DCHECK(manager);
118 121
119 TranslateEventDetails details(__FILE__, line, message); 122 TranslateEventDetails details(__FILE__, line, message);
120 manager->NotifyTranslateEvent(details); 123 manager->NotifyTranslateEvent(details);
121 } 124 }
122 125
123 // Parses |language_list| containing the list of languages that the translate 126 // Parses |language_list| containing the list of languages that the translate
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 // providing supported langauges list. 214 // providing supported langauges list.
212 for (size_t i = 0; i < arraysize(kDefaultSupportedLanguages); ++i) 215 for (size_t i = 0; i < arraysize(kDefaultSupportedLanguages); ++i)
213 supported_languages_.insert(kDefaultSupportedLanguages[i]); 216 supported_languages_.insert(kDefaultSupportedLanguages[i]);
214 UpdateSupportedLanguages(); 217 UpdateSupportedLanguages();
215 218
216 if (update_is_disabled) 219 if (update_is_disabled)
217 return; 220 return;
218 221
219 language_list_fetcher_.reset( 222 language_list_fetcher_.reset(
220 new TranslateURLFetcher(kFetcherIdForLanguageList)); 223 new TranslateURLFetcher(kFetcherIdForLanguageList));
224 language_list_fetcher_->set_max_retry_on_5xx(kMaxRetryOn5xx);
225
221 alpha_language_list_fetcher_.reset( 226 alpha_language_list_fetcher_.reset(
222 new TranslateURLFetcher(kFetcherIdForAlphaLanguageList)); 227 new TranslateURLFetcher(kFetcherIdForAlphaLanguageList));
228 alpha_language_list_fetcher_->set_max_retry_on_5xx(kMaxRetryOn5xx);
223 } 229 }
224 230
225 TranslateLanguageList::~TranslateLanguageList() { 231 TranslateLanguageList::~TranslateLanguageList() {
226 } 232 }
227 233
228 void TranslateLanguageList::GetSupportedLanguages( 234 void TranslateLanguageList::GetSupportedLanguages(
229 std::vector<std::string>* languages) { 235 std::vector<std::string>* languages) {
230 DCHECK(languages && languages->empty()); 236 DCHECK(languages && languages->empty());
231 std::set<std::string>::const_iterator iter = all_supported_languages_.begin(); 237 std::set<std::string>::const_iterator iter = all_supported_languages_.begin();
232 for (; iter != all_supported_languages_.end(); ++iter) 238 for (; iter != all_supported_languages_.end(); ++iter)
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 iter != supported_languages_.end(); 364 iter != supported_languages_.end();
359 ++iter) { 365 ++iter) {
360 all_supported_languages_.insert(*iter); 366 all_supported_languages_.insert(*iter);
361 } 367 }
362 for (iter = supported_alpha_languages_.begin(); 368 for (iter = supported_alpha_languages_.begin();
363 iter != supported_alpha_languages_.end(); 369 iter != supported_alpha_languages_.end();
364 ++iter) { 370 ++iter) {
365 all_supported_languages_.insert(*iter); 371 all_supported_languages_.insert(*iter);
366 } 372 }
367 } 373 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/translate/translate_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698