Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 17390017: Allow for lists of lists when summarizing performance results (Closed)

Created:
7 years, 6 months ago by Eric Willigers
Modified:
7 years, 6 months ago
Reviewers:
bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Allow for lists of lists when summarizing performance results Using page-repeat and pageset-repeat options in commands like tools/perf/run_measurement --browser=release --page-repeat=2 --pageset-repeat=3 blink_perf third_party/WebKit/PerformanceTests/Parser/html-parser.html previously let to a crash in _MeanAndStdDevFromList. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207426

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix nits #

Patch Set 3 : Fix inconsistent plural in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M build/android/pylib/perf_tests_helper.py View 1 2 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Eric Willigers
7 years, 6 months ago (2013-06-19 07:13:34 UTC) #1
bulach
lgtm, thanks! some style nits below. https://codereview.chromium.org/17390017/diff/1/build/android/pylib/perf_tests_helper.py File build/android/pylib/perf_tests_helper.py (right): https://codereview.chromium.org/17390017/diff/1/build/android/pylib/perf_tests_helper.py#newcode24 build/android/pylib/perf_tests_helper.py:24: nit: add another ...
7 years, 6 months ago (2013-06-19 12:19:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/17390017/6001
7 years, 6 months ago (2013-06-20 01:55:04 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 14:02:42 UTC) #4
Message was sent while issue was closed.
Change committed as 207426

Powered by Google App Engine
This is Rietveld 408576698