 Chromium Code Reviews
 Chromium Code Reviews Issue 17385010:
  OpenSSL/NSS implementation of ProofVerfifier.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 17385010:
  OpenSSL/NSS implementation of ProofVerfifier.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: net/quic/crypto/crypto_handshake.h | 
| diff --git a/net/quic/crypto/crypto_handshake.h b/net/quic/crypto/crypto_handshake.h | 
| index 919f7775a3a666dc8a1378caa549d46abb2c9aac..e702bb66871924b5bc008d8f8eb2b7b35c96af42 100644 | 
| --- a/net/quic/crypto/crypto_handshake.h | 
| +++ b/net/quic/crypto/crypto_handshake.h | 
| @@ -273,6 +273,7 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig { | 
| const std::vector<std::string>& certs() const; | 
| const std::string& signature() const; | 
| bool proof_valid() const; | 
| + uint64 generation_counter() const; | 
| void set_source_address_token(base::StringPiece token); | 
| @@ -283,8 +284,12 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig { | 
| std::vector<std::string> certs_; // A list of certificates in leaf-first | 
| // order. | 
| std::string server_config_sig_; // A signature of |server_config_|. | 
| - bool server_config_valid_; // true if |server_config_| is correctly signed | 
| - // and |certs_| has been validated. | 
| + bool server_config_valid_; // True if |server_config_| is correctly | 
| + // signed and |certs_| has been | 
| + // validated. | 
| + uint64 generation_counter_; // Generation counter associated with | 
| + // the |server_config_|, |certs_| and | 
| + // |server_config_sig_| combination. | 
| 
wtc
2013/07/03 00:20:26
Nit: it would be nice to point out that generation
 
ramant (doing other things)
2013/07/03 05:46:34
Done.
 | 
| // scfg contains the cached, parsed value of |server_config|. | 
| mutable scoped_ptr<CryptoHandshakeMessage> scfg_; | 
| @@ -348,7 +353,7 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig { | 
| QuicCryptoNegotiatedParameters* out_params, | 
| std::string* error_details); | 
| - const ProofVerifier* proof_verifier() const; | 
| + ProofVerifier* proof_verifier() const; | 
| // SetProofVerifier takes ownership of a |ProofVerifier| that clients are | 
| // free to use in order to verify certificate chains from servers. If a |