Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: Source/core/css/mediaControlsAndroid.css

Issue 17382003: Sync Android <video controls> with the default controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: sync with the default controls Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/mediaControlsAndroid.css
diff --git a/Source/core/css/mediaControlsAndroid.css b/Source/core/css/mediaControlsAndroid.css
index 69bdd8d66a09a4ba4dbf5fce4d109a6a724561e7..a258fa734d4f6d79799b70a5ea9b76f9f3a05d4d 100644
--- a/Source/core/css/mediaControlsAndroid.css
+++ b/Source/core/css/mediaControlsAndroid.css
@@ -30,10 +30,14 @@ audio {
height: 35px;
}
-audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure {
+audio::-webkit-media-controls-enclosure {
height: 35px;
}
+video::-webkit-media-controls-enclosure {
qinmin 2013/09/20 14:52:09 why the difference between video and audio ?
philipj_slow 2013/09/22 08:11:48 There's a 5px difference in mediaControls.css as w
+ height: 40px;
+}
+
audio::-webkit-media-controls-overlay-enclosure {
display: none;
}
@@ -54,7 +58,6 @@ video::-webkit-media-controls-overlay-enclosure {
audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
height: 35px;
- border-radius: 0;
qinmin 2013/09/20 14:52:09 why this? no rounded corners?
philipj_slow 2013/09/22 08:11:48 I don't know why this was here, as you've probably
qinmin 2013/09/22 15:51:45 I don't think this aligns with desktop, desktop ch
philipj_slow 2013/09/25 17:01:47 Yes, and now Android does too. "border-radius: 0"
qinmin 2013/09/25 17:10:16 This looks like a bug we missed earlier when chang
}
audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698