Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: Source/core/css/mediaControlsAndroid.css

Issue 17382003: Sync Android <video controls> with the default controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: sync with the default controls Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. 2 * Copyright (C) 2012 Google Inc.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 12 matching lines...) Expand all
23 */ 23 */
24 24
25 /* Media controls for Chromium on Android */ 25 /* Media controls for Chromium on Android */
26 26
27 /* WARNING: This css file can only style <audio> and <video> elements */ 27 /* WARNING: This css file can only style <audio> and <video> elements */
28 28
29 audio { 29 audio {
30 height: 35px; 30 height: 35px;
31 } 31 }
32 32
33 audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure { 33 audio::-webkit-media-controls-enclosure {
34 height: 35px; 34 height: 35px;
35 } 35 }
36 36
37 video::-webkit-media-controls-enclosure {
qinmin 2013/09/20 14:52:09 why the difference between video and audio ?
philipj_slow 2013/09/22 08:11:48 There's a 5px difference in mediaControls.css as w
38 height: 40px;
39 }
40
37 audio::-webkit-media-controls-overlay-enclosure { 41 audio::-webkit-media-controls-overlay-enclosure {
38 display: none; 42 display: none;
39 } 43 }
40 44
41 video::-webkit-media-controls-overlay-enclosure { 45 video::-webkit-media-controls-overlay-enclosure {
42 display: flex; 46 display: flex;
43 position: relative; 47 position: relative;
44 flex-direction: column; 48 flex-direction: column;
45 justify-content: flex-end; 49 justify-content: flex-end;
46 align-items: center; 50 align-items: center;
47 flex: 1 1; 51 flex: 1 1;
48 width: 100%; 52 width: 100%;
49 max-width: 800px; 53 max-width: 800px;
50 text-indent: 0; 54 text-indent: 0;
51 box-sizing: border-box; 55 box-sizing: border-box;
52 overflow: hidden; 56 overflow: hidden;
53 } 57 }
54 58
55 audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel { 59 audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
56 height: 35px; 60 height: 35px;
57 border-radius: 0;
qinmin 2013/09/20 14:52:09 why this? no rounded corners?
philipj_slow 2013/09/22 08:11:48 I don't know why this was here, as you've probably
qinmin 2013/09/22 15:51:45 I don't think this aligns with desktop, desktop ch
philipj_slow 2013/09/25 17:01:47 Yes, and now Android does too. "border-radius: 0"
qinmin 2013/09/25 17:10:16 This looks like a bug we missed earlier when chang
58 } 61 }
59 62
60 audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-bu tton { 63 audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-bu tton {
61 display: none; 64 display: none;
62 } 65 }
63 66
64 video::-webkit-media-controls-overlay-play-button { 67 video::-webkit-media-controls-overlay-play-button {
65 -webkit-appearance: media-overlay-play-button; 68 -webkit-appearance: media-overlay-play-button;
66 display: flex; 69 display: flex;
67 position: absolute; 70 position: absolute;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 105
103 audio::-webkit-media-controls-fullscreen-button { 106 audio::-webkit-media-controls-fullscreen-button {
104 display: none; 107 display: none;
105 } 108 }
106 109
107 audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-medi a-controls-toggle-closed-captions-button { 110 audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-medi a-controls-toggle-closed-captions-button {
108 width: 35px; 111 width: 35px;
109 height: 35px; 112 height: 35px;
110 line-height: 35px; 113 line-height: 35px;
111 } 114 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698