Introduce toHTMLFormControlElement, and use it.

Source/WebKit/chromium/src/WebSearchableFormData.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 67 matching lines @@
     return form->document()->completeURL(action.isNull() ? "" : action).protocolIs("http");
 }
 
 // If the form does not have an activated submit button, the first submit
 // button is returned.
 HTMLFormControlElement* GetButtonToActivate(HTMLFormElement* form)
 {
     HTMLFormControlElement* firstSubmitButton = 0;
     // FIXME: Consider refactoring this code so that we don't call form->associatedElements() twice.
     for (Vector<FormAssociatedElement*>::const_iterator i(form->associatedElements().begin()); i != form->associatedElements().end(); ++i) {
-      if (!(*i)->isFormControlElement())
-          continue;
-      HTMLFormControlElement* formElement = static_cast<HTMLFormControlElement*>(*i);
-      if (formElement->isActivatedSubmit())
-          // There's a button that is already activated for submit, return 0.
-          return 0;
-      if (!firstSubmitButton && formElement->isSuccessfulSubmitButton())
-          firstSubmitButton = formElement;
+        if (!(*i)->isFormControlElement())
+            continue;
+        HTMLFormControlElement* control = toHTMLFormControlElement(*i);
+        if (control->isActivatedSubmit()) {
+            // There's a button that is already activated for submit, return 0.
+            return 0;
+        }
+        if (!firstSubmitButton && control->isSuccessfulSubmitButton())
+            firstSubmitButton = control;
     }
     return firstSubmitButton;
 }
 
 // Returns true if the selected state of all the options matches the default
 // selected state.
 bool IsSelectInDefaultState(HTMLSelectElement* select)
 {
     const Vector<HTMLElement*>& listItems = select->listItems();
     if (select->multiple() || select->size() > 1) {
@@ skipping 47 matching lines @@
 //  - A Password field
 //  - More than one text field
 HTMLInputElement* findSuitableSearchInputElement(const HTMLFormElement* form)
 {
     HTMLInputElement* textElement = 0;
     // FIXME: Consider refactoring this code so that we don't call form->associatedElements() twice.
     for (Vector<FormAssociatedElement*>::const_iterator i(form->associatedElements().begin()); i != form->associatedElements().end(); ++i) {
         if (!(*i)->isFormControlElement())
             continue;
 
-        HTMLFormControlElement* formElement = static_cast<HTMLFormControlElement*>(*i);
+        HTMLFormControlElement* control = toHTMLFormControlElement(*i);
 
-        if (formElement->isDisabledFormControl() || formElement->name().isNull())
+        if (control->isDisabledFormControl() || control->name().isNull())
             continue;
 
-        if (!IsInDefaultState(formElement) || formElement->hasTagName(HTMLNames::textareaTag))
+        if (!IsInDefaultState(control) || control->hasTagName(HTMLNames::textareaTag))
             return 0;
 
-        if (formElement->hasTagName(HTMLNames::inputTag) && formElement->willValidate()) {
-            const HTMLInputElement* input = static_cast<const HTMLInputElement*>(formElement);
+        if (control->hasTagName(HTMLNames::inputTag) && control->willValidate()) {
+            const HTMLInputElement* input = toHTMLInputElement(control);
 
             // Return nothing if a file upload field or a password field are found.
             if (input->isFileUpload() || input->isPasswordField())
                 return 0;
 
             if (input->isTextField()) {
                 if (textElement) {
                     // The auto-complete bar only knows how to fill in one value.
                     // This form has multiple fields; don't treat it as searchable.
                     return 0;
                 }
-                textElement = toHTMLInputElement(formElement);
+                textElement = toHTMLInputElement(control);
             }
         }
     }
     return textElement;
 }
 
 // Build a search string based on a given HTMLFormElement and HTMLInputElement
 // 
 // Search string output example from www.google.com:
 // "hl=en&source=hp&biw=1085&bih=854&q={searchTerms}&btnG=Google+Search&aq=f&aqi=&aql=&oq="
 // 
 // Return false if the provided HTMLInputElement is not found in the form
 bool buildSearchString(const HTMLFormElement* form, Vector<char>* encodedString, WTF::TextEncoding* encoding, const HTMLInputElement* textElement)
 {
     bool isElementFound = false;   
 
     // FIXME: Consider refactoring this code so that we don't call form->associatedElements() twice.
     for (Vector<FormAssociatedElement*>::const_iterator i(form->associatedElements().begin()); i != form->associatedElements().end(); ++i) {
         if (!(*i)->isFormControlElement())
             continue;
 
-        HTMLFormControlElement* formElement = static_cast<HTMLFormControlElement*>(*i);
+        HTMLFormControlElement* control = toHTMLFormControlElement(*i);
 
-        if (formElement->isDisabledFormControl() || formElement->name().isNull())
+        if (control->isDisabledFormControl() || control->name().isNull())
             continue;
 
         FormDataList dataList(*encoding);
-        if (!formElement->appendFormData(dataList, false))
+        if (!control->appendFormData(dataList, false))
             continue;
 
         const Vector<FormDataList::Item>& items = dataList.items();
 
         for (Vector<FormDataList::Item>::const_iterator j(items.begin()); j != items.end(); ++j) {
             // Handle ISINDEX / <input name=isindex> specially, but only if it's
             // the first entry.
             if (!encodedString->isEmpty() || j->data() != "isindex") {
                 if (!encodedString->isEmpty())
                     encodedString->append('&');
                 FormDataBuilder::encodeStringAsFormData(*encodedString, j->data());
                 encodedString->append('=');
             }
             ++j;
-            if (formElement == textElement) {
+            if (control == textElement) {
                 encodedString->append("{searchTerms}", 13);
                 isElementFound = true;
             } else
                 FormDataBuilder::encodeStringAsFormData(*encodedString, j->data());
         }
     }
     return isElementFound;
 }
 } // namespace
 
@@ skipping 50 matching lines @@
 
     String action(formElement->action());
     KURL url(formElement->document()->completeURL(action.isNull() ? "" : action));
     RefPtr<FormData> formData = FormData::create(encodedString);
     url.setQuery(formData->flattenToString());
     m_url = url;
     m_encoding = String(encoding.name()); 
 }
 
 } // namespace WebKit