Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 17379020: Get rid of RequestRegistry (part 5): each request cancels itself. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Get rid of RequestRegistry (part 5): each request cancels itself. There should be no behavior change. It's just moving code out of RequestRegistry. BUG=164098 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207847

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -94 lines) Patch
M chrome/browser/google_apis/base_requests.h View 5 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/google_apis/base_requests.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/google_apis/request_registry.h View 2 chunks +2 lines, -41 lines 0 comments Download
M chrome/browser/google_apis/request_registry.cc View 2 chunks +4 lines, -36 lines 0 comments Download
M chrome/browser/google_apis/request_sender.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
It's almost there. Next patch will be the last one.
7 years, 6 months ago (2013-06-21 07:16:22 UTC) #1
hashimoto
lgtm
7 years, 6 months ago (2013-06-21 07:22:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17379020/2001
7 years, 6 months ago (2013-06-21 07:24:56 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 16:10:44 UTC) #4
Message was sent while issue was closed.
Change committed as 207847

Powered by Google App Engine
This is Rietveld 408576698