Make ExceptionCode be an enum that does not encode the "code" property

Make ExceptionCode be an enum that does not encode the "code" property

This adds a new enum for the legacy error codes and use that to expose
the code in the binding.

BUG=251437
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152800

[jsbell, 2013-06-18 22:50:50]

lgtm

[commit-bot: I haz the power, 2013-06-19 16:41:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17379011/1

[commit-bot: I haz the power, 2013-06-19 16:50:00]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[arv (Not doing code reviews), 2013-06-19 17:02:40]

Missing LGTM from an OWNER for these files:
    public/web/WebStorageQuotaError.h

[dglazkov, 2013-06-19 17:03:59]

LGTM.

[jamesr, 2013-06-19 17:06:23]

lgtm, assuming these aren't persisted

[commit-bot: I haz the power, 2013-06-19 17:37:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17379011/1

[arv (Not doing code reviews), 2013-06-19 17:38:58]

Thanks Dimitri, James.

The *ErrorLegacyCode enum will go away soon.

[commit-bot: I haz the power, 2013-06-20 05:32:42]

Failed to apply patch for Source/core/dom/DOMCoreException.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/DOMCoreException.cpp
  Hunk #1 FAILED at 30.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/dom/DOMCoreException.cpp.rej

Patch:       Source/core/dom/DOMCoreException.cpp
Index: Source/core/dom/DOMCoreException.cpp
diff --git a/Source/core/dom/DOMCoreException.cpp
b/Source/core/dom/DOMCoreException.cpp
index
10488d509ded725443c4324d10847a8479aad611..67b9c78608a58f67b7285844f2949b14c93e0769
100644
--- a/Source/core/dom/DOMCoreException.cpp
+++ b/Source/core/dom/DOMCoreException.cpp
@@ -30,54 +30,69 @@
 #include "core/dom/DOMCoreException.h"
 
 #include "DOMException.h"
+#include "ExceptionCode.h"
 
 namespace WebCore {
 
 static struct CoreException {
     const char* const name;
     const char* const description;
+    const int code;
 } coreExceptions[] = {
-    { "IndexSizeError", "Index or size was negative, or greater than the
allowed value." },
-    { 0, 0 }, // DOMStringSizeError
-    { "HierarchyRequestError", "A Node was inserted somewhere it doesn't
belong." },
-    { "WrongDocumentError", "A Node was used in a different document than the
one that created it (that doesn't support it)." },
-    { "InvalidCharacterError", "An invalid or illegal character was specified,
such as in an XML name." },
-    { 0, 0 }, // NoDataAllowedError
-    { "NoModificationAllowedError", "An attempt was made to modify an object
where modifications are not allowed." },
-    { "NotFoundError", "An attempt was made to reference a Node in a context
where it does not exist." },
-    { "NotSupportedError", "The implementation did not support the requested
type of object or operation." },
-    { "InUseAttributeError", "An attempt was made to add an attribute that is
already in use elsewhere." },
-    { "InvalidStateError", "An attempt was made to use an object that is not,
or is no longer, usable." },
-    { "SyntaxError", "An invalid or illegal string was specified." },
-    { "InvalidModificationError", "An attempt was made to modify the type of
the underlying object." },
-    { "NamespaceError", "An attempt was made to create or change an object in a
way which is incorrect with regard to namespaces." },
-    { "InvalidAccessError", "A parameter or an operation was not supported by
the underlying object." },
-    { 0, 0 }, // ValidationError
-    { "TypeMismatchError", "The type of an object was incompatible with the
expected type of the parameter associated to the object." },
-    { "SecurityError", "An attempt was made to break through the security
policy of the user agent." },
-    // FIXME: Couldn't find a description in the HTML/DOM specifications for
NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR
-    { "NetworkError", "A network error occurred." },
-    { "AbortError", "The user aborted a request." },
-    { "URLMismatchError", "A worker global scope represented an absolute URL
that is not equal to the resulting absolute URL." },
-    { "QuotaExceededError", "An attempt was made to add something to storage
that exceeded the quota." },
-    { "TimeoutError", "A timeout occurred." },
-    { "InvalidNodeTypeError", "The supplied node is invalid or has an invalid
ancestor for this operation." },
-    { "DataCloneError", "An object could not be cloned." }
+    { "IndexSizeError", "Index or size was negative, or greater than the
allowed value.", IndexSizeErrorLegacyCode },
+    { "HierarchyRequestError", "A Node was inserted somewhere it doesn't
belong.", HierarchyRequestErrorLegacyCode },
+    { "WrongDocumentError", "A Node was used in a different document than the
one that created it (that doesn't support it).", WrongDocumentErrorLegacyCode },
+    { "InvalidCharacterError", "An invalid or illegal character was specified,
such as in an XML name.", InvalidCharacterErrorLegacyCode },
+    { "NoModificationAllowedError", "An attempt was made to modify an object
where modifications are not allowed.", NoModificationAllowedErrorLegacyCode },
+    { "NotFoundError", "An attempt was made to reference a Node in a context
where it does not exist.", NotFoundErrorLegacyCode },
+    { "NotSupportedError", "The implementation did not support the requested
type of object or operation.", NotSupportedErrorLegacyCode },
+    { "InUseAttributeError", "An attempt was made to add an attribute that is
already in use elsewhere.", InuseAttributeErrorLegacyCode },
+    { "InvalidStateError", "An attempt was made to use an object that is not,
or is no longer, usable.", InvalidStateErrorLegacyCode },
+    { "SyntaxError", "An invalid or illegal string was specified.",
SyntaxErrorLegacyCode },
+    { "InvalidModificationError", "An attempt was made to modify the type of
the underlying object.", InvalidModificationErrorLegacyCode },
+    { "NamespaceError", "An attempt was made to create or change an object in a
way which is incorrect with regard to namespaces.", NamespaceErrorLegacyCode },
+    { "InvalidAccessError", "A parameter or an operation was not supported by
the underlying object.", InvalidAccessErrorLegacyCode },
+    { "TypeMismatchError", "The type of an object was incompatible with the
expected type of the parameter associated to the object.",
TypeMismatchErrorLegacyCode },
+    { "SecurityError", "An attempt was made to break through the security
policy of the user agent.", SecurityErrorLegacyCode },
+    // FIXME: Couldn't find a description in the HTML/DOM specifications for
NETWORKERR, ABORTERR, URLMISMATCHERR, and QUOTAEXCEEDEDERR
+    { "NetworkError", "A network error occurred.", NetworkErrorLegacyCode },
+    { "AbortError", "The user aborted a request.", AbortErrorLegacyCode },
+    { "URLMismatchError", "A worker global scope represented an absolute URL
that is not equal to the resulting absolute URL.", UrlMismatchErrorLegacyCode },
+    { "QuotaExceededError", "An attempt was made to add something to storage
that exceeded the quota.", QuotaExceededErrorLegacyCode },
+    { "TimeoutError", "A timeout occurred.", TimeoutErrorLegacyCode },
+    { "InvalidNodeTypeError", "The supplied node is invalid or has an invalid
ancestor for this operation.", InvalidNodeTypeErrorLegacyCode },
+    { "DataCloneError", "An object could not be cloned.",
DataCloneErrorLegacyCode }
 };
 
+static const CoreException* getErrorEntry(ExceptionCode ec)
+{
+    size_t tableSize = WTF_ARRAY_LENGTH(coreExceptions);
+    size_t tableIndex = ec - INDEX_SIZE_ERR;
+
+    return tableIndex < tableSize ? &coreExceptions[tableIndex] : 0;
+}
+
 bool DOMCoreException::initializeDescription(ExceptionCode ec,
ExceptionCodeDescription* description)
 {
+    const CoreException* entry = getErrorEntry(ec);
+    if (!entry)
+        return false;
+
     description->typeName = "DOM";
-    description->code = ec;
     description->type = DOMCoreExceptionType;
+    description->name = entry->name;
+    description->description = entry->description;
+    description->code = entry->code;
 
-    size_t tableSize = WTF_ARRAY_LENGTH(coreExceptions);
-    size_t tableIndex = ec - INDEX_SIZE_ERR;
+    return true;
+}
 
-    description->name = tableIndex < tableSize ?
coreExceptions[tableIndex].name : 0;
-    description->description = tableIndex < tableSize ?
coreExceptions[tableIndex].description : 0;
+int DOMCoreException::getLegacyErrorCode(ExceptionCode ec)
+{
+    const CoreException* entry = getErrorEntry(ec);
+    ASSERT(entry);
 
-    return true;
+    return (entry && entry->code) ? entry->code : 0;
 }
 
 } // namespace WebCore

[commit-bot: I haz the power, 2013-06-20 16:06:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17379011/19001

[commit-bot: I haz the power, 2013-06-20 17:25:29]

Change committed as 152800