Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issue 17377004: Resolves crash in media::ChannelMixer::Transform (Closed)

Created:
7 years, 6 months ago by henrika (OOO until Aug 14)
Modified:
7 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Resolves crash in media::ChannelMixer::Transform. New version ensures that input and output bus to/from the channel mixer has the same size. BUG=250947 TEST=Verified that unified audio clients crashed when input device used mono and we did resampling (e.g. 16->32). For this case, different audio bus sizes were used by the channel mixer. Using the fix, the channel mixer now always uses input and output buses of the same size (320 and 320 in the case above) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M media/audio/win/audio_unified_win.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Dale, I must have tried a case where I don't do resampling, but only channel ...
7 years, 6 months ago (2013-06-18 09:45:00 UTC) #1
DaleCurtis
lgtm, I'll CQ for you.
7 years, 6 months ago (2013-06-18 16:57:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/17377004/1
7 years, 6 months ago (2013-06-18 16:57:42 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 19:17:30 UTC) #4
Message was sent while issue was closed.
Change committed as 207053

Powered by Google App Engine
This is Rietveld 408576698