Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 17376004: Use TestBrowserThreadBundle in c/b/google_apis. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Use TestBrowserThreadBundle in c/b/google_apis. Tested routines has UI thread assertion, and net stack requires IO loop. Hence we use real thread here. BUG=247551 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M chrome/browser/google_apis/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
Gave up thinking about making the tests single threaded.
7 years, 6 months ago (2013-06-18 08:47:47 UTC) #1
hashimoto
lgtm
7 years, 6 months ago (2013-06-18 09:02:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17376004/1
7 years, 6 months ago (2013-06-18 09:03:20 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 14:15:28 UTC) #4
Message was sent while issue was closed.
Change committed as 206986

Powered by Google App Engine
This is Rietveld 408576698