Hook up HTML5 fullscreen video notifications to tabCapture API

Hook up HTML5 fullscreen video notifications to tabCapture API

BUG=222287
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207400

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207600

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207741

[Matt Perry, 2013-06-18 21:13:02]

lgtm

https://codereview.chromium.org/17354003/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right):

https://codereview.chromium.org/17354003/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:156: const
bool is_fullscreen = *(content::Details<bool>(details).ptr());
fyi, outer parens are unnecessary

[justinlin, 2013-06-18 21:36:21]

thanks

https://codereview.chromium.org/17354003/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right):

https://codereview.chromium.org/17354003/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:156: const
bool is_fullscreen = *(content::Details<bool>(details).ptr());
On 2013/06/18 21:13:02, Matt Perry wrote:
> fyi, outer parens are unnecessary

Done.

[commit-bot: I haz the power, 2013-06-18 21:36:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justinlin@chromium.org/17354003/5001

[commit-bot: I haz the power, 2013-06-18 21:55:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justinlin@chromium.org/17354003/24001

[commit-bot: I haz the power, 2013-06-18 21:55:06]

Failed to apply patch for
chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
  Hunk #1 FAILED at 10.
  Hunk #2 succeeded at 109 (offset 2 lines).
  Hunk #3 succeeded at 134 (offset 2 lines).
  Hunk #4 succeeded at 152 (offset 2 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc.rej

Patch:       chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
Index: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
index
105a0933e8410cd0f570ba657ae0804b74343794..e10e747cb880f6dcdcaa6a353fbc1a00733cd0e2
100644
--- a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
@@ -10,10 +10,12 @@
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/fullscreen/fullscreen_controller.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include
"components/browser_context_keyed_service/browser_context_dependency_manager.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
@@ -107,7 +109,9 @@ TabCaptureRegistry::TabCaptureRegistry(Profile* profile)
   registrar_.Add(this,
                  chrome::NOTIFICATION_EXTENSION_UNLOADED,
                  content::Source<Profile>(profile_));
-  // TODO(justinlin): Hook up HTML5 fullscreen.
+  registrar_.Add(this,
+                 chrome::NOTIFICATION_FULLSCREEN_CHANGED,
+                 content::NotificationService::AllSources());
 }
 
 TabCaptureRegistry::~TabCaptureRegistry() {
@@ -130,6 +134,7 @@ const TabCaptureRegistry::RegistryCaptureInfo
 void TabCaptureRegistry::Observe(int type,
                                  const content::NotificationSource& source,
                                  const content::NotificationDetails& details) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   switch (type) {
     case chrome::NOTIFICATION_EXTENSION_UNLOADED: {
       // Cleanup all the requested media streams for this extension.
@@ -147,7 +152,36 @@ void TabCaptureRegistry::Observe(int type,
       break;
     }
     case chrome::NOTIFICATION_FULLSCREEN_CHANGED: {
-      // TODO(justinlin): Hook up HTML5 fullscreen.
+      FullscreenController* fullscreen_controller =
+          content::Source<FullscreenController>(source).ptr();
+      const bool is_fullscreen = *content::Details<bool>(details).ptr();
+      for (ScopedVector<TabCaptureRequest>::iterator it = requests_.begin();
+           it != requests_.end(); ++it) {
+        // If we are exiting fullscreen mode, we only need to check if any of
+        // the requests had the fullscreen flag toggled previously. The
+        // fullscreen controller no longer has the reference to the fullscreen
+        // web_contents here.
+        if (!is_fullscreen) {
+          if ((*it)->fullscreen) {
+            (*it)->fullscreen = false;
+            DispatchStatusChangeEvent(*it);
+            break;
+          }
+          continue;
+        }
+
+        // If we are entering fullscreen mode, find whether the web_contents we
+        // are capturing entered fullscreen mode.
+        content::RenderViewHost* const rvh =
+            content::RenderViewHost::FromID((*it)->render_process_id,
+                                            (*it)->render_view_id);
+        if (rvh && fullscreen_controller->IsFullscreenForTabOrPending(
+                content::WebContents::FromRenderViewHost(rvh))) {
+          (*it)->fullscreen = true;
+          DispatchStatusChangeEvent(*it);
+          break;
+        }
+      }
       break;
     }
   }

[commit-bot: I haz the power, 2013-06-18 22:02:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justinlin@chromium.org/17354003/31001

[commit-bot: I haz the power, 2013-06-19 00:23:31]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-19 03:36:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justinlin@chromium.org/17354003/16002

[commit-bot: I haz the power, 2013-06-20 11:42:11]

Change committed as 207400

[commit-bot: I haz the power, 2013-06-20 16:27:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justinlin@chromium.org/17354003/84001

[commit-bot: I haz the power, 2013-06-20 22:08:37]

Change committed as 207600

[commit-bot: I haz the power, 2013-06-21 01:53:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justinlin@chromium.org/17354003/105001

[commit-bot: I haz the power, 2013-06-21 07:03:40]

Change committed as 207741