Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: cc/resources/raster_worker_pool_perftest.cc

Issue 17351017: Re-land: cc: Add raster finished signals to RasterWorkerPool. (Closed) Base URL: http://git.chromium.org/chromium/src.git@new-graph-build
Patch Set: fix flaky unit tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/raster_worker_pool.cc ('k') | cc/resources/raster_worker_pool_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/raster_worker_pool_perftest.cc
diff --git a/cc/resources/raster_worker_pool_perftest.cc b/cc/resources/raster_worker_pool_perftest.cc
index f99184554e7ab5e567296f7d5bb6078b46a982e7..c8f1d8479c72c8a25e0fbff4fede81437a935d27 100644
--- a/cc/resources/raster_worker_pool_perftest.cc
+++ b/cc/resources/raster_worker_pool_perftest.cc
@@ -38,6 +38,12 @@ class PerfRasterWorkerPool : public RasterWorkerPool {
virtual void ScheduleTasks(RasterTask::Queue* queue) OVERRIDE {
NOTREACHED();
}
+ virtual void OnRasterTasksFinished() OVERRIDE {
+ NOTREACHED();
+ }
+ virtual void OnRasterTasksRequiredForActivationFinished() OVERRIDE {
+ NOTREACHED();
+ }
void SetRasterTasks(RasterTask::Queue* queue) {
RasterWorkerPool::SetRasterTasks(queue);
@@ -56,7 +62,24 @@ class PerfRasterWorkerPool : public RasterWorkerPool {
}
void BuildTaskGraph() {
- RasterTaskGraph graph;
+ unsigned priority = 0;
+ TaskGraph graph;
+
+ scoped_refptr<internal::WorkerPoolTask>
+ raster_required_for_activation_finished_task(
+ CreateRasterRequiredForActivationFinishedTask());
+ internal::GraphNode* raster_required_for_activation_finished_node =
+ CreateGraphNodeForTask(
+ raster_required_for_activation_finished_task.get(),
+ priority++,
+ &graph);
+
+ scoped_refptr<internal::WorkerPoolTask> raster_finished_task(
+ CreateRasterFinishedTask());
+ internal::GraphNode* raster_finished_node =
+ CreateGraphNodeForTask(raster_finished_task.get(),
+ priority++,
+ &graph);
for (RasterTaskVector::const_iterator it = raster_tasks().begin();
it != raster_tasks().end(); ++it) {
@@ -66,7 +89,21 @@ class PerfRasterWorkerPool : public RasterWorkerPool {
DCHECK(perf_it != perf_tasks_.end());
if (perf_it != perf_tasks_.end()) {
internal::WorkerPoolTask* perf_task = perf_it->second.get();
- graph.InsertRasterTask(perf_task, task->dependencies());
+
+ internal::GraphNode* perf_node =
+ CreateGraphNodeForRasterTask(perf_task,
+ task->dependencies(),
+ priority++,
+ &graph);
+
+ if (IsRasterTaskRequiredForActivation(task)) {
+ raster_required_for_activation_finished_node->add_dependency();
+ perf_node->add_dependent(
+ raster_required_for_activation_finished_node);
+ }
+
+ raster_finished_node->add_dependency();
+ perf_node->add_dependent(raster_finished_node);
}
}
}
« no previous file with comments | « cc/resources/raster_worker_pool.cc ('k') | cc/resources/raster_worker_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698