Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: base/version.cc

Issue 17351015: Small comment correction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 // This throws out things like +3, or 032. 43 // This throws out things like +3, or 032.
44 if (IntToString(num) != *it) 44 if (IntToString(num) != *it)
45 return false; 45 return false;
46 46
47 parsed->push_back(static_cast<uint16>(num)); 47 parsed->push_back(static_cast<uint16>(num));
48 } 48 }
49 return true; 49 return true;
50 } 50 }
51 51
52 // Compares version components in |components1| with components in 52 // Compares version components in |components1| with components in
53 // |components2|. Returns -1, 0 or 1 if |components1| is greater than, equal to, 53 // |components2|. Returns -1, 0 or 1 if |components1| is less than, equal to,
54 // or less than |components2|, respectively. 54 // or greater than |components2|, respectively.
55 int CompareVersionComponents(const std::vector<uint16>& components1, 55 int CompareVersionComponents(const std::vector<uint16>& components1,
56 const std::vector<uint16>& components2) { 56 const std::vector<uint16>& components2) {
57 const size_t count = std::min(components1.size(), components2.size()); 57 const size_t count = std::min(components1.size(), components2.size());
58 for (size_t i = 0; i < count; ++i) { 58 for (size_t i = 0; i < count; ++i) {
59 if (components1[i] > components2[i]) 59 if (components1[i] > components2[i])
60 return 1; 60 return 1;
61 if (components1[i] < components2[i]) 61 if (components1[i] < components2[i])
62 return -1; 62 return -1;
63 } 63 }
64 if (components1.size() > components2.size()) { 64 if (components1.size() > components2.size()) {
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 size_t count = components_.size(); 167 size_t count = components_.size();
168 for (size_t i = 0; i < count - 1; ++i) { 168 for (size_t i = 0; i < count - 1; ++i) {
169 version_str.append(IntToString(components_[i])); 169 version_str.append(IntToString(components_[i]));
170 version_str.append("."); 170 version_str.append(".");
171 } 171 }
172 version_str.append(IntToString(components_[count - 1])); 172 version_str.append(IntToString(components_[count - 1]));
173 return version_str; 173 return version_str;
174 } 174 }
175 175
176 } // namespace base 176 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698