Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 17351003: Rename ContextDestructionObserver to ContextLifecycleObserver (Closed)

Created:
7 years, 6 months ago by Hajime Morrita
Modified:
7 years, 6 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, chromiumbugtracker_adobe.com, feature-media-reviews_chromium.org, webcomponents-bugzilla_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, mkwst+watchlist_chromium.org, Nate Chapin, vcarbune.chromium, do-not-use
Visibility:
Public.

Description

Rename ContextDestructionObserver to ContextLifecycleObserver This sheer rename is a followup of r152682, where we introduce ContextLifecycleNotifier. TEST=none BUG=none R=abarth R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152703

Patch Set 1 #

Patch Set 2 : Reapplied #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -215 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ActiveDOMCallback.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ActiveDOMCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/ActiveDOMObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/dom/ContextDestructionObserver.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/dom/ContextDestructionObserver.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
A + Source/core/dom/ContextLifecycleObserver.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/dom/ContextLifecycleObserver.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycleObserver.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DocumentLifecycleObserver.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/NamedFlowCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NamedFlowCollection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptExecutionContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/ScriptExecutionContext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DOMSecurityPolicy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/DOMSecurityPolicy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStream.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/performance/WorkerPerformance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/performance/WorkerPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Hajime Morrita
rubbestamp please?
7 years, 6 months ago (2013-06-19 02:49:45 UTC) #1
haraken
LGTM
7 years, 6 months ago (2013-06-19 03:18:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/17351003/1
7 years, 6 months ago (2013-06-19 03:37:41 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/modules/mediastream/MediaStream.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-19 03:37:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/17351003/6001
7 years, 6 months ago (2013-06-19 03:53:27 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 06:06:09 UTC) #6
Message was sent while issue was closed.
Change committed as 152703

Powered by Google App Engine
This is Rietveld 408576698