Issue 17350003: gpu: Add more context labelling.

Issue 17350003: gpu: Add more context labelling. (Closed)

Created:
7 years, 6 months ago by epenner

Modified:
7 years, 5 months ago

Reviewers:
gman1, jamesr, enne (OOO), no sievers, danakj

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@GPU_add_context_names

Visibility:
Public.

More Reviews

Description

gpu: Add more context labelling. Make sure names are unique in different renderers, and add one for offscreen renderer context (used for filters). The offscreen context is created lazily, so the label is also applied lazily. BUG=242999, 233101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209284

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Rebase. #

Patch Set 4 : Fix nit. #

Patch Set 5 : Fix build. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -4 lines)			Patch
M	cc/output/delegating_renderer.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	cc/output/gl_renderer.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	cc/output/gl_renderer.cc	View	1 2 3 4	6 chunks	+26 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/image_transport_factory_android.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

no sievers

On 2013/06/20 23:04:28, epenner wrote: > Rebased. Ptal. lgtm

7 years, 6 months ago (2013-06-20 23:11:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/17350003/4001

7 years, 6 months ago (2013-06-24 20:34:08 UTC) #5

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=11958

7 years, 6 months ago (2013-06-24 21:53:55 UTC) #6

epenner

jamesr@/enne@, I just need a reviewer for gl_renderer/delegating_renderer.

7 years, 6 months ago (2013-06-24 22:37:52 UTC) #7

danakj

cc/ LGTM https://codereview.chromium.org/17350003/diff/4001/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/17350003/diff/4001/cc/output/gl_renderer.cc#newcode3051 cc/output/gl_renderer.cc:3051: if (!offscreen_context_labelled_) { nit: if (labelled) return;

7 years, 5 months ago (2013-06-25 15:02:19 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/17350003/20001

7 years, 5 months ago (2013-06-28 23:49:46 UTC) #9

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 5 months ago (2013-06-29 01:06:46 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/17350003/20001

7 years, 5 months ago (2013-06-29 01:13:43 UTC) #11

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 5 months ago (2013-06-29 01:20:15 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/17350003/48001

7 years, 5 months ago (2013-06-29 01:37:53 UTC) #13

Message was sent while issue was closed.

Change committed as 209284

Expand Messages | Collapse Messages