Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 17348007: Disable large address aware mode for SyzyASAN builds. (Closed)

Created:
7 years, 6 months ago by chrisha
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

Disable large address aware mode for SyzyASAN builds. SyzyASAN requires double the shadow memory to accomodate this change, which would incur a significantly higher OOM rate for canary channel users. This reverts https://codereview.chromium.org/17029013/ when 'asan=1' is defined. BUG=https://code.google.com/p/sawbuck/issues/detail?id=72 BUG=239803 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207398

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/common.gypi View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
chrisha
PTAL.
7 years, 6 months ago (2013-06-18 21:50:24 UTC) #1
chrisha
Ping?
7 years, 6 months ago (2013-06-19 14:10:39 UTC) #2
Sigurður Ásgeirsson
lgtm
7 years, 6 months ago (2013-06-19 14:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/17348007/2001
7 years, 6 months ago (2013-06-19 14:11:30 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 10:47:44 UTC) #5
Message was sent while issue was closed.
Change committed as 207398

Powered by Google App Engine
This is Rietveld 408576698