Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 17341006: [Password Autofill] Don't fill fields with autocomplete="off". (Closed)

Created:
7 years, 6 months ago by Ilya Sherman
Modified:
7 years, 6 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Password Autofill] Don't fill fields with autocomplete="off". BUG=252609 TEST=out/Debug/browser_tests --gtest_filter=PasswordAutofillAgentTest.NoInitialAutocompleteForAutocompleteOff R=gcasto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
7 years, 6 months ago (2013-06-21 06:14:10 UTC) #1
Garrett Casto
lgtm
7 years, 6 months ago (2013-06-21 18:05:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/17341006/1
7 years, 6 months ago (2013-06-21 18:05:55 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 00:33:47 UTC) #4
Message was sent while issue was closed.
Change committed as 207971

Powered by Google App Engine
This is Rietveld 408576698