Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 17341004: Don't rely on the second argument to DOMTokenList.toggle in about:policy. (Closed)

Created:
7 years, 6 months ago by Joao da Silva
Modified:
7 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Don't rely on the second argument to DOMTokenList.toggle in about:policy. This argument is not standardized and is not implemented by Webkit on iOS, making the page unusable when included on iOS builds. BUG=252537 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/resources/policy.js View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
PTAL @James: iOS doesn't include this code by default yet, but we're working on it.
7 years, 6 months ago (2013-06-21 02:07:24 UTC) #1
Mattias Nissler (ping if slow)
LGTM
7 years, 6 months ago (2013-06-21 05:50:20 UTC) #2
James Hawkins
lgtm
7 years, 6 months ago (2013-06-21 14:56:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/17341004/1
7 years, 6 months ago (2013-06-21 16:19:35 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 21:20:23 UTC) #5
Message was sent while issue was closed.
Change committed as 207924

Powered by Google App Engine
This is Rietveld 408576698