Issue 17338002: Add LayoutTests for MediaSource codec config changes.

Issue 17338002: Add LayoutTests for MediaSource codec config changes. (Closed)

Created:
7 years, 6 months ago by acolwell GONE FROM CHROMIUM

Modified:
7 years, 6 months ago

Reviewers:
adamk, scherkus (not reviewing)

CC:
blink-reviews, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add LayoutTests for MediaSource codec config changes. This patch tests codec configuration changes that are allowed during the middle of playback when the MediaSource API is being used. These tests construct 2 second presentations that alternate between 2 different codec configurations every 0.5 seconds. Frame size, frame rate, and bitrate changes are for both MP4 and WebM content are being tested. The script used to generate the media files and HTML files for these tests is also included in this patch to make it easier to regenerate the media files and add new tests. BUG=239506 TEST=LayoutTests/http/tests/media/media-source/mediasource-config-change*.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152761

Patch Set 1 #

Total comments: 18

Patch Set 2 : Address CR comments #

Total comments: 7

Patch Set 3 : Make pylint happy and other CR fixes #

Patch Set 4 : Removed media files and placed them in another patch. #

Total comments: 14

Patch Set 5 : Fix python style #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+654 lines, -3 lines)			Patch
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-a-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-a-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-av-framesize.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-av-framesize-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-v-bitrate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-v-bitrate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-v-framerate.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-v-framerate-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-v-framesize.html	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-change-webm-v-framesize-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/media-source/mediasource-config-changes.js	View	1 2	1 chunk	+78 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/media/media-source/mediasource-util.js	View		3 chunks	+4 lines, -3 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py	View	1 2 3 4	1 chunk	+226 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-a-128k-44100Hz-1ch-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-a-192k-44100Hz-1ch-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-v-128k-320x240-24fps-8kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-v-128k-320x240-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-v-128k-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/mp4/test-v-256k-320x240-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-a-128k-44100Hz-1ch-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-a-192k-44100Hz-1ch-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-v-128k-320x240-24fps-8kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-v-128k-320x240-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-v-128k-640x480-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/media/resources/media-source/webm/test-v-256k-320x240-30fps-10kfr-manifest.json	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

There are a few things to note w/ this patch: 1. MP4 test expectations show ...

7 years, 6 months ago (2013-06-17 23:50:18 UTC) #1

scherkus (not reviewing)

No clue how much people care about style on HTML, but anyway ... I've commonly ...

7 years, 6 months ago (2013-06-18 01:22:09 UTC) #2

acolwell GONE FROM CHROMIUM

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-config-changes.js File LayoutTests/http/tests/media/media-source/mediasource-config-changes.js (right): https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-config-changes.js#newcode26 LayoutTests/http/tests/media/media-source/mediasource-config-changes.js:26: mediasource_configchange_test = function(directory, idA, idB, description) On 2013/06/18 01:22:09, ...

7 years, 6 months ago (2013-06-18 16:33:45 UTC) #3

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
File LayoutTests/http/tests/media/media-source/mediasource-config-changes.js
(right):

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/media-source/mediasource-config-changes.js:26:
mediasource_configchange_test = function(directory, idA, idB, description)
On 2013/06/18 01:22:09, scherkus wrote:
> any reason not to use a normal function declaration? AFAIK it's equivalent
since
> your HTML includes this script before <body>
> 
> function mediasource_configchange_test(...) { }
Done. Not sure why I originally did this.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/media-source/mediasource-config-changes.js:77: },
description, { timeout: 10000} );
On 2013/06/18 01:22:09, scherkus wrote:
> space after 10000
Done.

> 
> also ... timeouts!? :(
This just increases the default test timeout that testharness.js uses for these
tests. Since this plays back content for ~2 seconds and the default timeout is 2
seconds, there was no headroom for bot slowness.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
File
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py
(right):

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:16:
# This is a script that generates the content and HTML files for Media Source
On 2013/06/18 01:22:09, scherkus wrote:
> this is usually a """triple quote string containing the description"""

Done.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:20:
duration = 2
On 2013/06/18 01:22:09, scherkus wrote:
> constants are ALL_CAPS

Done.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:59:
def Run(cmdline):
On 2013/06/18 01:22:09, scherkus wrote:
> the pythonic way of doing command lines is typically with a list of strings
that
> gets .join(' ')ed at the very end
> 
> ... in other words any time you catch yourself doing the following:
> cmdline += " blah"
> 
> ... it should be:
> cmdline.append("blah")

Done. Used += [...] form in most places since it seemed more compact and still
in the spirit of your suggestion.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:64:
# Create JSON manifest
On 2013/06/18 01:22:09, scherkus wrote:
> import json module?

Done.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:95:
template = "<!DOCTYPE html>\n"
On 2013/06/18 01:22:09, scherkus wrote:
> this can be a """triple quote string""" and you can drop the \n as a result

Done.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:107:
template += "          mediasource_configchange_test('%s', '%s', '%s', '%s');\n"
On 2013/06/18 01:22:09, scherkus wrote:
> given this is a pretty hefty string with a couple of params I'd recommend
using
> variable names for these format specifiers
> 
> "hello %(foo)s" % { 'foo': 'world' }
> --> "hello world"

Done.

https://codereview.chromium.org/17338002/diff/1/LayoutTests/http/tests/media/...
LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:187:
if len(encoding_ids) < len(encode_settings) :
On 2013/06/18 01:22:09, scherkus wrote:
> remove space before :

Done.

adamk

For the Python style question, the Blink guide is here: http://www.chromium.org/blink/coding-style#TOC-Python The main thing that's ...

7 years, 6 months ago (2013-06-18 21:54:23 UTC) #4

acolwell GONE FROM CHROMIUM

On 2013/06/18 21:54:23, adamk wrote: > For the Python style question, the Blink guide is ...

7 years, 6 months ago (2013-06-18 23:00:10 UTC) #5

acolwell GONE FROM CHROMIUM

https://codereview.chromium.org/17338002/diff/6001/LayoutTests/http/tests/media/media-source/mediasource-config-changes.js File LayoutTests/http/tests/media/media-source/mediasource-config-changes.js (right): https://codereview.chromium.org/17338002/diff/6001/LayoutTests/http/tests/media/media-source/mediasource-config-changes.js#newcode26 LayoutTests/http/tests/media/media-source/mediasource-config-changes.js:26: function mediasource_configchange_test(directory, idA, idB, description) On 2013/06/18 21:54:23, adamk ...

7 years, 6 months ago (2013-06-18 23:00:18 UTC) #6

acolwell GONE FROM CHROMIUM

Removed media files and placed them in another patch (https://codereview.chromium.org/17385022/) so they can be landed ...

7 years, 6 months ago (2013-06-18 23:26:23 UTC) #7

scherkus (not reviewing)

html is all good your python needs to be PEPpier (ho ho ho ho) https://chromiumcodereview.appspot.com/17338002/diff/12002/LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py ...

7 years, 6 months ago (2013-06-19 00:10:30 UTC) #8

adamk

lgtm once scherkus is happy. Thanks for the explanation about timing; let's keep an eye ...

7 years, 6 months ago (2013-06-19 00:22:36 UTC) #9

acolwell GONE FROM CHROMIUM

https://codereview.chromium.org/17338002/diff/12002/LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py File LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py (right): https://codereview.chromium.org/17338002/diff/12002/LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py#newcode42 LayoutTests/http/tests/media/resources/media-source/generate-config-change-tests.py:42: { 'fs': '320x240', 'fr': 24, 'kfr': 8, 'c': '#ff0000', ...

7 years, 6 months ago (2013-06-19 00:48:03 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/17338002/19001

7 years, 6 months ago (2013-06-20 01:45:08 UTC) #12

Message was sent while issue was closed.

Change committed as 152761

Expand Messages | Collapse Messages