Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 17336002: Make the PNaCl is not-yet-installed error messages easier to read. (Closed)

Created:
7 years, 6 months ago by jvoung (off chromium)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make the PNaCl is-not-yet-installed error messages easier to read. This changes the lastError code, but doesn't do any checks at an earlier stage. Changes message from "NaCl module load failed: PnaclCoordinator: blah..." to "NaCl module load failed: The Portable Native Client component is not installed or has been disabled." BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207718

Patch Set 1 #

Patch Set 2 : rebase... oops committed part before #

Patch Set 3 : rebase #

Patch Set 4 : new use of report #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 1 2 3 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvoung (off chromium)
7 years, 6 months ago (2013-06-17 23:29:23 UTC) #1
jvoung (off chromium)
+dschuff
7 years, 6 months ago (2013-06-19 21:42:16 UTC) #2
sehr
lgtm
7 years, 6 months ago (2013-06-20 21:13:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/17336002/9001
7 years, 6 months ago (2013-06-20 21:54:17 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 05:34:40 UTC) #5
Message was sent while issue was closed.
Change committed as 207718

Powered by Google App Engine
This is Rietveld 408576698