Time to kill googleurl.gyp

Time to kill googleurl.gyp

Now that Blink has rolled into chromium we can move on and remove googleurl.gyp
from build/temp_gyp!

BUG=229660
R=thestig@chromium.org,darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208034

[tfarina, 2013-06-19 22:59:50]

Lei build/
Darin webkit/
Brett fyi.

Thanks,

[Lei Zhang, 2013-06-19 22:59:56]

Yay! One nit though:

https://codereview.chromium.org/17335013/diff/1/webkit/glue/webkit_glue.gypi
File webkit/glue/webkit_glue.gypi (right):

https://codereview.chromium.org/17335013/diff/1/webkit/glue/webkit_glue.gypi#...
webkit/glue/webkit_glue.gypi:207: '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
If you look in the other files, 'W' comes before [a-z] there too. That's because
these have been sorted in ASCII order, like when you run Unix sort with LANG=C.
In LANG=en_US.UTF-8, [a-z] comes before 'W', and in other locales... who knows.
Thus we stick with LANG=C and what was there is correct.

[tfarina, 2013-06-19 23:07:48]

https://codereview.chromium.org/17335013/diff/1/webkit/glue/webkit_glue.gypi
File webkit/glue/webkit_glue.gypi (right):

https://codereview.chromium.org/17335013/diff/1/webkit/glue/webkit_glue.gypi#...
webkit/glue/webkit_glue.gypi:207: '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
On 2013/06/19 22:59:57, Lei Zhang wrote:
> If you look in the other files, 'W' comes before [a-z] there too. That's
because
> these have been sorted in ASCII order, like when you run Unix sort with
LANG=C.
> In LANG=en_US.UTF-8, [a-z] comes before 'W', and in other locales... who
knows.
> Thus we stick with LANG=C and what was there is correct.
Ops, reverted.

[darin (slow to review), 2013-06-20 03:57:19]

LGTM

https://codereview.chromium.org/17335013/diff/5001/webkit/storage_renderer.gyp
File webkit/storage_renderer.gyp (right):

https://codereview.chromium.org/17335013/diff/5001/webkit/storage_renderer.gy...
webkit/storage_renderer.gyp:15: '<(DEPTH)/url/url.gyp:url_lib',
any reason why the target isn't just "url"?  it seems nice if we can strive for
naming our targets consistently so that they are easy to remember.  i realize
that so few of our targets follow this convention :-/

[Lei Zhang, 2013-06-20 04:01:37]

On 2013/06/20 03:57:19, darin wrote:
> LGTM
> 
> https://codereview.chromium.org/17335013/diff/5001/webkit/storage_renderer.gyp
> File webkit/storage_renderer.gyp (right):
> 
>
https://codereview.chromium.org/17335013/diff/5001/webkit/storage_renderer.gy...
> webkit/storage_renderer.gyp:15: '<(DEPTH)/url/url.gyp:url_lib',
> any reason why the target isn't just "url"?  it seems nice if we can strive
for
> naming our targets consistently so that they are easy to remember.  i realize
> that so few of our targets follow this convention :-/

Oh I can answer this one. Naming it url will produce a url.dll in component
builds. It turns out Windows already has a url.dll and having 2 blows WinXP's
mind.

[darin (slow to review), 2013-06-20 04:38:12]

that's awesome :-/  thanks for the explanation.


On Wed, Jun 19, 2013 at 9:01 PM, <thestig@chromium.org> wrote:

> On 2013/06/20 03:57:19, darin wrote:
>
>> LGTM
>>
>
>  https://codereview.chromium.**org/17335013/diff/5001/webkit/**
>>
storage_renderer.gyp<https://codereview.chromium.org/17335013/diff/5001/webkit/storage_renderer.gyp>
>> File webkit/storage_renderer.gyp (right):
>>
>
>
> https://codereview.chromium.**org/17335013/diff/5001/webkit/**
>
storage_renderer.gyp#newcode15<https://codereview.chromium.org/17335013/diff/5001/webkit/storage_renderer.gyp#newcode15>
>
>> webkit/storage_renderer.gyp:**15: '<(DEPTH)/url/url.gyp:url_lib'**,
>> any reason why the target isn't just "url"?  it seems nice if we can
>> strive
>>
> for
>
>> naming our targets consistently so that they are easy to remember.  i
>> realize
>> that so few of our targets follow this convention :-/
>>
>
> Oh I can answer this one. Naming it url will produce a url.dll in component
> builds. It turns out Windows already has a url.dll and having 2 blows
> WinXP's
> mind.
>
>
https://codereview.chromium.**org/17335013/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-06-22 00:36:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/17335013/5001

[commit-bot: I haz the power, 2013-06-22 00:36:25]

Failed to apply patch for webkit/glue/webkit_glue.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file webkit/glue/webkit_glue.gypi
  Hunk #1 FAILED at 203.
  1 out of 1 hunk FAILED -- saving rejects to file
webkit/glue/webkit_glue.gypi.rej

Patch:       webkit/glue/webkit_glue.gypi
Index: webkit/glue/webkit_glue.gypi
diff --git a/webkit/glue/webkit_glue.gypi b/webkit/glue/webkit_glue.gypi
index
f37c46909c887ca3c2eba7c9b3722804cebd6c1f..0bb7ed3f1eee1ecbe70dc36585a7352458343008
100644
--- a/webkit/glue/webkit_glue.gypi
+++ b/webkit/glue/webkit_glue.gypi
@@ -203,11 +203,11 @@
       'dependencies': [
         '<(DEPTH)/base/base.gyp:base',
         '<(DEPTH)/base/base.gyp:base_i18n',
-        '<(DEPTH)/build/temp_gyp/googleurl.gyp:googleurl',
         '<(DEPTH)/skia/skia.gyp:skia',
         '<(DEPTH)/third_party/WebKit/public/blink.gyp:blink',
         '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
         '<(DEPTH)/ui/ui.gyp:ui',
+        '<(DEPTH)/url/url.gyp:url_lib',
         'glue_common',
         'webkit_common',
       ],

[commit-bot: I haz the power, 2013-06-22 01:31:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/17335013/18001

[commit-bot: I haz the power, 2013-06-22 02:39:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/17335013/18001

[commit-bot: I haz the power, 2013-06-22 03:25:25]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps,
chromedriver2_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, gpu_unittests, interactive_ui_tests,
ipc_tests, jingle_unittests, media_unittests, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests,
sandbox_linux_unittests, sql_unittests, sync_integration_tests, sync_unit_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-06-22 12:14:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/17335013/18001

[commit-bot: I haz the power, 2013-06-22 14:20:12]

Change committed as 208034